fix: Add authentication to support-scheduler actions #4419
Conversation
Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4419 +/- ##
==========================================
- Coverage 41.76% 41.73% -0.03%
==========================================
Files 106 106
Lines 9740 9749 +9
==========================================
+ Hits 4068 4069 +1
- Misses 5325 5333 +8
Partials 347 347
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| _, err := utils.SendRequestWithRESTAddress(m.lc, action.Content, action.ContentType, restAddress) | ||
|
|
||
| var jwtSecretProvider clientInterfaces.AuthenticationInjector | ||
| // Awaiting change to go-mod-core-contracts |
There was a problem hiding this comment.
Is this still valid? Waiting foe what? Should start with a TODO: so readers know it needs to be addressed.
There was a problem hiding this comment.
Changed the code without removing the comment. Yes, this is done. (Will fix.)
There was a problem hiding this comment.
Misleading comment removed in fac7cbe
Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@lenny-intel Ready for re-review. |
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
The easiest way to test this change is to modify support-scheduler configuration.toml and set the Midnight interval to a period of "5m" (five minutes). Then make docker (make clean_docker_base docker_base docker), then from edgex-compose/compose-builder run make run dev. Then do docker logs -f edgex-core-data and wait for the following log message to appear:
If the incoming JWT length == 0, then this fix didn't catch and try again. Otherwise, the request will be authorized after this fix.
New Dependency Instructions (If applicable)