feat!: consume common config #4335
Conversation
ejlee3
force-pushed
the
load-common-config
branch
from
0d55944
to
b5f4f76
Compare
| StartupMsg = "This is the Core Command Microservice" | ||
| MaxResultCount = 1024 | ||
| MaxRequestSize = 0 # Not curently used. Defines the maximum size of http request body in bytes | ||
| RequestTimeout = "45s" |
There was a problem hiding this comment.
@cloudxxx8 , Wow, we need to confirm that this override should be here.
BREAKING CHANGE: removes the common config information for core services closes edgexfoundry#4263 Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
ejlee3
force-pushed
the
load-common-config
branch
3 times, most recently
from
3e465cb
to
27d945e
Compare
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
ejlee3
force-pushed
the
load-common-config
branch
from
27d945e
to
f00b6e5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4335 +/- ##
==========================================
- Coverage 43.59% 43.59% -0.01%
==========================================
Files 116 116
Lines 10714 10719 +5
==========================================
+ Hits 4671 4673 +2
- Misses 5624 5627 +3
Partials 419 419
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lenny-goodell
changed the title
|
The snap tests were failing with such error from several services: Does this have something to do with the missing config bootstrapper (#4306) in the snap? |
|
Yes. This is being worked on today. |
BREAKING CHANGE: removes the common config information for core services
closes #4263
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
make dockerto build the docker imagesmake run no-secty devfor non-secure mode testing ormake run devfor secure mode testing.New Dependency Instructions (If applicable)