Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing edgex/security config stem resolution in security-consul-bootstrapper #4110

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

jim-wang-intel
Copy link
Contributor

bug fixes

Fixes: #4109

Signed-off-by: Jim Wang (Intel) yutsung.jim.wang@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • [x ] I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) same unit tests for regression
  • [x ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  1. when using docker-compose please include security-spiffe-token-provider in the edgex-compose builder, i.e.: make run dev delayed-start or make gen dev delayed-start
  2. compose it up if using make gen
  3. observed that the spiffe-token-provider runs without error log message, ie. docker logs edgex-security-spiffe-token-provider

New Dependency Instructions (If applicable)

…nsul-bootstrapper

Fixes: edgexfoundry#4109

Signed-off-by: Jim Wang (Intel) <yutsung.jim.wang@intel.com>
@jim-wang-intel jim-wang-intel added bug Something isn't working security-services labels Jul 29, 2022
@jim-wang-intel jim-wang-intel self-assigned this Jul 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4110 (1483eb5) into main (4804402) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4110      +/-   ##
==========================================
- Coverage   47.36%   47.35%   -0.01%     
==========================================
  Files         114      114              
  Lines        9874     9876       +2     
==========================================
  Hits         4677     4677              
- Misses       4808     4809       +1     
- Partials      389      390       +1     
Impacted Files Coverage Δ
.../security/bootstrapper/command/setupacl/command.go 71.87% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4804402...1483eb5. Read the comment docs.

@jim-wang-intel jim-wang-intel merged commit a991377 into edgexfoundry:main Jul 29, 2022
@jim-wang-intel jim-wang-intel deleted the fix-issue-4109 branch July 29, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security-services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Missing edgex/security config stem in consul-bootstrapper
4 participants