Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to node 11 #60

Closed
j3j5 opened this issue Apr 24, 2019 · 5 comments
Closed

Revert to node 11 #60

j3j5 opened this issue Apr 24, 2019 · 5 comments

Comments

@j3j5
Copy link

j3j5 commented Apr 24, 2019

Hi, is there a way to revert the node version to 11? My builds are failing due to sass/node-sass#2633, which is blocked and won't be merged till the people from node implement the NaN version.

Could you release a tag with node 11, at least till node-sass is fixed? Any other suggestions?

Thanks.

@edbizarro
Copy link
Owner

edbizarro commented Apr 24, 2019

Sure!, node-saas package is very problematic indeed.

I'll keep an eye on that issue to update to node 12 only after they fix the problem.

In the meantime. the alpine images have a lts version, if you're using it, just append -lts in the image name until the build of v11 finished.

@j3j5
Copy link
Author

j3j5 commented Apr 24, 2019

Thank you very much, unfortunately I'm not using alpine atm but, since you mention it I'm going to try if migrating the image for our builds isn't too problematic. I can't remember why we weren't using it in the first place but is worth a try.

Obrigado pelo seu ótimo trabalho.

@edbizarro edbizarro changed the title Revert to node 111 Revert to node 11 Apr 24, 2019
@edbizarro
Copy link
Owner

All images (except lts) are changed back to Node v11

@edbizarro
Copy link
Owner

Version node-saas/v4.12.0 was released with support for node v12.

I'm going to close this issue and update all images to v12 again.

@j3j5
Copy link
Author

j3j5 commented Apr 27, 2019

Great, thanks for the quick action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants