Check completion proposal is compatible or not.

[jdneo]

• Early return if the completion proposal is not compatible with the expected type.

[testforstephen]

https://github.com/eclipse/eclipse.jdt.ls/blob/1cd21c63ff65d369415179e4b93dc4ca09e1a9ac/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/CompletionProposalReplacementProvider.java#L804-L810

Previously, we had to use type hierarchy to find the inheritance path between the proposed type and the expected type for each constructor completion proposal. This was slow for a long proposal list. Now we can use the cached compatibility between the proposed type and the expected type to filter out the proposals that are not inherited earlier. This makes sense for performance improvement.

LGTM.

[fbricon]

Continuing the discussion here

The returned completion proposal from JDT Core won't contain MyClass.MyList(). Besides, if the completion is triggered after MyL|, MyClass.MyList() is not in the proposal list either. (Same result in Eclipse).

So we have no chance to check isCompatible in this case.

I don't expect MyClass.MyList() to be proposed (although with chained completion that would be possible I guess), but today I can do :

then once MyClass is selected, can complete on MyList.

With the new change I wouldn't be able to complete on MyClass.
I understand the appeal about performance, but I'm not comfortable losing that, when we don't have tow-tiered completion like IDEA, where "everybody's welcome" is used by default but you can switch to "isCompatible" by doing Shift+Ctrl+space

[jdneo]

Wired...

I tried the completion with v1.20.2023062804 (without this PR), and I got following list:

It only has MyClass(), but no MyClass. (You wish to have MyClass without the () right?)

Is there any special setting to make MyClass appear in the list?

[fbricon]

you probably have MyClass down the list. In my case, I selected once already so I believe VS Code might have bumped its priority to put it up the list.

[fbricon]

also try MyC, then trigger completion

[jdneo]

Checked the inner class case. It's working with this PR actually. I added a new test case to cover that.

[testforstephen]

Checked the inner class case. It's working with this PR actually. I added a new test case to cover that.

since it doesn't break the case Fred mentioned, I think we can merge this PR now.