Latest NLS translations #20222
Open
Latest NLS translations #20222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
approved these changes
Sep 24, 2024
|
Jenkins compile amac jdk17 |
|
|
It looks like translation permuted the placeholders, but didn't qualify them with indices (e.g. |
|
It appears that the messages must specify argument indices if any language needs to insert the values in another order: |
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Jenkins compile amac jdk17 |
|
Updated and compiling now. |
keithc-ca
reviewed
Sep 24, 2024
| @@ -6913,3 +6908,36 @@ J9NLS_SHRC_OSCACHE_MMAP_STARTUP_JITSERVER_LAYER_FILE_DELETE_ERROR.explanation=Th | |||
| J9NLS_SHRC_OSCACHE_MMAP_STARTUP_JITSERVER_LAYER_FILE_DELETE_ERROR.system_action=The JVM continues. | |||
| J9NLS_SHRC_OSCACHE_MMAP_STARTUP_JITSERVER_LAYER_FILE_DELETE_ERROR.user_response=Contact your service representative. | |||
| # END NON-TRANSLATABLE | |||
|
|
|||
| J9NLS_CC_OSPAGE_SIZE_MISMATCH_V1=La mida de p\u00e0gina ( %1$zu ) del sistema operatiu \u00e9s diferent de la mida de p\u00e0gina ( %2$zu ) del sistema en qu\u00e8 es crea la mem\u00f2ria cau de la capa %3$d . | |||
There was a problem hiding this comment.
Did the automation add the spaces inside the parentheses? I don't think we want them. They're not added universally, e.g. they're not added for de, fr or it.
There was a problem hiding this comment.
Yes the automation added them. We could remove them manually but then would always have to fix this up when doing future translations, which I don't want to do. I suggest we just accept them, they aren't harmful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.