Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEP 328 Flight Recorder #1876

Open
pshipton opened this issue May 9, 2018 · 10 comments
Open

JEP 328 Flight Recorder #1876

pshipton opened this issue May 9, 2018 · 10 comments

Comments

@pshipton
Copy link
Member

pshipton commented May 9, 2018

https://bugs.openjdk.java.net/browse/JDK-8193393

This is an "Epic" to contain requirements for supporting this JEP on OpenJ9.

@pshipton
Copy link
Member Author

I don't believe there are any plans to implement this.
@DanHeidinga

@fjeremic
Copy link
Contributor

Isn't this something we are still looking into? What is the alternative for OpenJ9? HealthCenter?

@DanHeidinga
Copy link
Member

Isn't this something we are still looking into? What is the alternative for OpenJ9? HealthCenter?

Currently, Healthcenter is the alternative for OpenJ9. This is an area we're looking more broadly to determine the right way to get metrics out of the JVM. FlightRecorder is one option but it's not the only one.

Closing this makes sense as this item is unlikely to be the best place to track OpenJ9's final approach to this area

@MariusVolkhart
Copy link

@DanHeidinga is there another public location where one can follow along or join the conversation about OpenJ9's approach?

I'm primarily interested in how to do custom events on OpenJ9 (jdk.jfr.* and jdk.jfr.consumer.* equivalents). I looked through various Eclipse and IBM documentation but didn't see this functionality pop up.

@danjhop3
Copy link

IT IS NEEDED AT A JAR LEVEL

@DanHeidinga
Copy link
Member

DanHeidinga commented Aug 16, 2021

I'm primarily interested in how to do custom events on OpenJ9 (jdk.jfr.* and jdk.jfr.consumer.* equivalents). I looked through various Eclipse and IBM documentation but didn't see this functionality pop up.

Does the Trace Java API [1] provide the required functionality? It allows the application to register tracepoints and inject them into the per-thread tracebuffers. These are - by default - an in-memory ring buffer that records the last few events or can be redirected to a file.

is there another public location where one can follow along or join the conversation about OpenJ9's approach?

This is a really good question. IBM HealthCenter is owned by IBM and to my knowledge, hasn't been opened sourced. The OpenJ9 project had relied on HealthCenter for historical reasons (and because HC supported OpenJ9 and was available). I'm not sure what the current state of HC is and what kind of resources are behind it today. Maybe @mstoodle or @pshipton can comment?

This may be an area we need to re-investigate if the current path still works or if we should give JFR / Mission Control another look

@mstoodle
Copy link
Contributor

You're right, it hasn't been open sourced, although nothing to my knowledge would stop us from doing it (other than the fact that it would probably be pretty close to a dump and run :( ). There are a few people who help out with support for HC, but no dedicated resourcing right now.

I would support reopening the discussion to look at JFR / Mission Control, but unfortunately can't commit people to help with such an effort. This is an area where we could really use some help. I'd like to believe the existing hook/trace framework represents some significant fraction of the work that would be needed if we were to go down that path (so we wouldn't be starting from nothing: many of the needed hook points are probably already there), but that doesn't mean there wouldn't still be a fair amount of work needed :( .

@Wood-Xia
Copy link
Contributor

Wood-Xia commented Sep 3, 2021

I also strongly support to reopen this discussion.
When we switch from OpenJDK to OpenJ9, we are happy with its low memory footprint.
Well, when we are looking for some profiling tool as JFR which is cool, we are a little disappointed....

@monwolf
Copy link

monwolf commented Sep 23, 2021

We are at the same point, we are really happy with the low memory footprint but we lost a good capacity of our current APM system that is the real-time profiling of the APP.

@pshipton
Copy link
Member Author

pshipton commented Sep 20, 2024

Re-opening since there is active development on JFR for OpenJ9 now.
https://github.com/eclipse-openj9/openj9/pulls?q=is%3Apr+is%3Aopen+jfr

@pshipton pshipton reopened this Sep 20, 2024
@pshipton pshipton added the jfr label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants