Fix #3252 Add support for scoping the search operations

[gayanper]

The current version support scoping the following search operations

• reference search
• call hierarchy search

with the following scopes to choose from

• all : includes all classpath entries
• main: all classpath entries excluding test

[rgrunber]

Seems very reasonable. I guess we don't have to add it to

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeLensHandler.java

Lines 262 to 265 in 3ca99cb

	private IJavaSearchScope createSearchScope() throws JavaModelException {
	IJavaProject[] projects = JavaCore.create(ResourcesPlugin.getWorkspace().getRoot()).getJavaProjects();
	return SearchEngine.createJavaSearchScope(projects, IJavaSearchScope.SOURCES);
	}

because that only deals with source references ? So the number of references in the references code lens will still match what the references view shows. What about workspace symbol search

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceSymbolHandler.java

Lines 124 to 130 in 3ca99cb

	int scope = IJavaSearchScope.REFERENCED_PROJECTS | IJavaSearchScope.SOURCES;
	PreferenceManager preferenceManager = JavaLanguageServerPlugin.getPreferencesManager();
	if (!sourceOnly && preferenceManager != null && preferenceManager.isClientSupportsClassFileContent()) {
	scope |= IJavaSearchScope.APPLICATION_LIBRARIES | IJavaSearchScope.SYSTEM_LIBRARIES;
	}
	return SearchEngine.createJavaSearchScope(targetProjects, scope);

?

[gayanper]

Seems very reasonable. I guess we don't have to add it to

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeLensHandler.java

Lines 262 to 265 in 3ca99cb

	private IJavaSearchScope createSearchScope() throws JavaModelException {
	IJavaProject[] projects = JavaCore.create(ResourcesPlugin.getWorkspace().getRoot()).getJavaProjects();
	return SearchEngine.createJavaSearchScope(projects, IJavaSearchScope.SOURCES);
	}

because that only deals with source references ? So the number of references in the references code lens will still match what the references view shows. What about workspace symbol search

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceSymbolHandler.java

Lines 124 to 130 in 3ca99cb

	int scope = IJavaSearchScope.REFERENCED_PROJECTS | IJavaSearchScope.SOURCES;
	PreferenceManager preferenceManager = JavaLanguageServerPlugin.getPreferencesManager();
	if (!sourceOnly && preferenceManager != null && preferenceManager.isClientSupportsClassFileContent()) {
	scope |= IJavaSearchScope.APPLICATION_LIBRARIES | IJavaSearchScope.SYSTEM_LIBRARIES;
	}
	return SearchEngine.createJavaSearchScope(targetProjects, scope);

?

Good point, I think we should add there as well, because

• IJavaSearchScope.SOURCES : This consider both main and test code as well isn't it ?
• WorkspaceSymbols : I think we should add there as well, so that it is much straight forward for user when they switch the scope.

WDYT ?

[rgrunber]

You're right :

With main set, the references view correctly shows 1 reference while code lens references still show 2 (1 coming from a test folder).

We definitely need to adjust CodeLensHandler. I guess I must have thought that SOURCES meant just things part of the runtime but that's wrong. It clearly includes test references.

Agreed on WorkspaceSymbols.

[gayanper]

We definitely need to adjust CodeLensHandler. I guess I must have thought that SOURCES meant just things part of the runtime but that's wrong. It clearly includes test references.

Add support for code lens reference.

[rgrunber]

Looks fine overall. What about having the workspace symbol search respect this search scope as well ?

I could see this being useful as a bunch of times, I find myself wishing I could exclude everything with 'test' in it when I do a generic text search.

[gayanper]

bad habit :( , I rebase against master and force push the changes due to target file outdated. Hope it will be ok with you, my new changes on workspace symbols are on a new commit though.