Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests for Postgres persistence #394

Closed
paullatzelsperger opened this issue Jul 11, 2024 · 0 comments · Fixed by #401
Closed

Add E2E tests for Postgres persistence #394

paullatzelsperger opened this issue Jul 11, 2024 · 0 comments · Fixed by #401
Assignees
@wolf4ood
Labels
enhancement New feature or request

Comments

@paullatzelsperger
Copy link
Member

Feature Request

All E2E tests in IdentityHub are currently based on im-memory stores. This should be improved using the pattern we have in EDC, where there is an InMemory and a Postgres variant of the tests.

Which Areas Would Be Affected?

E2E tests

Why Is the Feature Desired?

test coverage. some errors only pop up when actual persistence is used.

Solution Proposal

use the pattern we have in EDC, using a base test class and nested subclasses
@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Jul 11, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Jul 11, 2024
@wolf4ood wolf4ood self-assigned this Jul 16, 2024
@wolf4ood wolf4ood removed the triage all new issues awaiting classification label Jul 16, 2024
@wolf4ood wolf4ood mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolf4ood wolf4ood

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement SQL variants for E2E tests wolf4ood/IdentityHub
2 participants
@wolf4ood @paullatzelsperger