Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lighthouse domhtml is going away #1

Closed
paulirish opened this issue Jan 5, 2018 · 1 comment
Closed

lighthouse domhtml is going away #1

paulirish opened this issue Jan 5, 2018 · 1 comment

Comments

@paulirish
Copy link

heya! cool project! :)

btw i have a PR that will change the default output from domhtml to html. GoogleChrome/lighthouse#4176

looks like this package will require a small change. might as well tweak these regexes to handle both cases:

lighthouseR/R/lighthouse.R

Lines 40 to 42 in ea7cea4

output <- s[grep("GMT Printer domhtml output written to", s)]
output <-
gsub(".* GMT Printer domhtml output written to ", "", output)

cheers!
@dschmeh
Copy link
Owner

dschmeh commented Jan 12, 2018

@paulirish Thank you! I changed the function so it can process both.

@dschmeh dschmeh closed this as completed Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @dschmeh