From 5f0c5e0d728ef089d81f8aeeb47a6ffa43250eef Mon Sep 17 00:00:00 2001 From: Andrew Hyndman Date: Tue, 11 Apr 2023 14:57:26 -0500 Subject: [PATCH] Report discarded meadurements and cancellation in debug mode (#71) Co-authored-by: Andrew Hyndman --- src/visuallyCompleteCalculator.ts | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/src/visuallyCompleteCalculator.ts b/src/visuallyCompleteCalculator.ts index 9ae0c56..63ddb7a 100644 --- a/src/visuallyCompleteCalculator.ts +++ b/src/visuallyCompleteCalculator.ts @@ -78,6 +78,12 @@ class VisuallyCompleteCalculator { /** abort the current TTVC measurement */ cancel() { + Logger.info( + 'VisuallyCompleteCalculator.cancel()', + '::', + 'index =', + this.activeMeasurementIndex + ); this.activeMeasurementIndex = undefined; } @@ -85,7 +91,7 @@ class VisuallyCompleteCalculator { async start(start = 0) { const navigationIndex = (this.navigationCount += 1); this.activeMeasurementIndex = navigationIndex; - Logger.info('VisuallyCompleteCalculator.start()'); + Logger.info('VisuallyCompleteCalculator.start()', '::', 'index =', navigationIndex); // setup const cancel = () => { @@ -128,6 +134,13 @@ class VisuallyCompleteCalculator { : this.lastMutation, }, }); + } else { + Logger.debug( + 'VisuallyCompleteCalculator: Measurement discarded', + '::', + 'index =', + navigationIndex + ); } // cleanup @@ -160,9 +173,12 @@ class VisuallyCompleteCalculator { 'lastImageLoadTimestamp =', this.lastImageLoadTimestamp, 'lastMutationTimestamp =', - this.lastMutation?.timestamp ?? 0 + this.lastMutation?.timestamp ?? 0, + '::', + 'index =', + this.activeMeasurementIndex ); - Logger.info('TTVC:', measurement); + Logger.info('TTVC:', measurement, '::', 'index =', this.activeMeasurementIndex); this.subscribers.forEach((subscriber) => subscriber(measurement)); }