Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rounding of values #147

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix rounding of values #147

merged 1 commit into from
Sep 19, 2022

Conversation

driesvints
Copy link
Owner

No description provided.

@driesvints driesvints merged commit ad68c52 into 3.x Sep 19, 2022
@driesvints driesvints deleted the fix-tests branch September 19, 2022 09:41
@AidasK
Copy link

AidasK commented Sep 6, 2023

@driesvints Just wanted to point out that such rounding is not always correct since round function poorly handles float values. Example:
image
Instead we could use bcmath function or return float value as before and leave this issue for the implementation app.

@driesvints
Copy link
Owner Author

Thanks @AidasK. Would welcome a PR with some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants