Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some code #42775

Merged
merged 11 commits into from
Sep 20, 2024
Merged

Clean up some code #42775

merged 11 commits into from
Sep 20, 2024
+67 −37

Conversation

marcpopMSFT
Copy link
Member

@marcpopMSFT marcpopMSFT commented Aug 15, 2024 •
edited
Loading

Check the unzip path before extracting to it
Switch to XxHash3 and XxHash64 which is for non-security usage.

@marcpopMSFT marcpopMSFT requested a review from a team as a code owner August 15, 2024 23:44
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Aug 15, 2024
javiercn
javiercn approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the Blazor changes.

@marcpopMSFT
Copy link
Member Author

@dotnet/product-construction I'm getting VMR synchronization failures in this PR in the VMR and source build legs. Any ideas?
Failed to apply the patch root-95dad63-298b71f-1.patch to /.

@MichaelSimons
Copy link
Member

@dotnet/product-construction I'm getting VMR synchronization failures in this PR in the VMR and source build legs. Any ideas? Failed to apply the patch root-95dad63-298b71f-1.patch to /.

@premun

This was referenced Aug 22, 2024
Open
Open
Open
@premun
Copy link
Member

premun commented Aug 23, 2024

@MichaelSimons I suspect it might be the readme after all. I forgot we're no longer generating on the fly from the template as we moved the component list into its own file. I reverted the README changes in the VMR

@premun
Copy link
Member

premun commented Aug 23, 2024

/azp run sdk-source-build

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@premun
Copy link
Member

premun commented Aug 23, 2024

/azp run sdk-unified-build

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Sep 4, 2024
Open
@marcpopMSFT
Copy link
Member Author

Appears to be hitting the new known templating test issue.

@marcpopMSFT
Copy link
Member Author

/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@marcpopMSFT
Copy link
Member Author

Suppression was approved.

@marcpopMSFT marcpopMSFT merged commit cf81c08 into main Sep 20, 2024
37 checks passed
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-codecleanup branch September 20, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar left review comments

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks left review comments

@KalleOlaviNiemitalo KalleOlaviNiemitalo KalleOlaviNiemitalo left review comments

@javiercn javiercn javiercn approved these changes

@joeloff joeloff joeloff approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@marcpopMSFT @MichaelSimons @premun @jaredpar @GrabYourPitchforks @javiercn @joeloff @KalleOlaviNiemitalo