Fix issues with SqlCommandSet not working with Byte Array parameters
#1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still need tests for System.Data.SqlClient. It is a separate library shipped in a separate distribution. |
Done! |
karinazhou
approved these changes
Jan 17, 2020
|
The System.Data.SqlClient package is being deleted from master by #2275 . If you believe that this is important bug to warrant servicing fix, it should go to https://github.com/dotnet/corefx/tree/release/3.1 . |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports fix to System.Data.SqlClient from dotnet/SqlClient#360.
Tests not added as Microsoft.Data.SqlClient tests are now covering this scenario.