diff --git a/Directory.Build.targets b/Directory.Build.targets index f731eedc390c3..8a06a9c58756f 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -201,29 +201,4 @@ - - - - true - true - true - - true - true - true - - -$(VersionSuffix) - $(MajorVersion).$(MinorVersion) - $(ProductBandVersion).$(PatchVersion) - $(ProductionVersion)$(ProductVersionSuffix) - - $(ProductVersion) - $(SharedFrameworkNugetVersion) - Runtime/$(SharedFrameworkNugetVersion)/ - - - diff --git a/eng/Publishing.props b/eng/Publishing.props index 1507fc850339d..61b953f75c0c0 100644 --- a/eng/Publishing.props +++ b/eng/Publishing.props @@ -1,39 +1,193 @@ - + true + + false + + $(TargetArchitecture) - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + + + + + + + + - - - + + + + + + + + + + + + + + + + + + + + + + diff --git a/eng/Signing.props b/eng/Signing.props index f76a7aa22c248..34875b1d14d96 100644 --- a/eng/Signing.props +++ b/eng/Signing.props @@ -1,21 +1,16 @@ - - - true + + + true + + false - - - @@ -37,12 +32,6 @@ - - - - - @@ -55,14 +44,30 @@ - - - - - + + + + + %(FullPath).sha512 + + - - - + + + + diff --git a/eng/Subsets.props b/eng/Subsets.props index cbe9cfc7d73c9..e2772f05f1f71 100644 --- a/eng/Subsets.props +++ b/eng/Subsets.props @@ -198,7 +198,6 @@ - @@ -548,10 +547,6 @@ - - - - diff --git a/eng/pipelines/official/jobs/prepare-signed-artifacts.yml b/eng/pipelines/official/jobs/prepare-signed-artifacts.yml index 908f2b64c71c2..f4bfa85478d9d 100644 --- a/eng/pipelines/official/jobs/prepare-signed-artifacts.yml +++ b/eng/pipelines/official/jobs/prepare-signed-artifacts.yml @@ -46,10 +46,9 @@ jobs: checkDownloadedFiles: true - script: >- - build.cmd -ci - -subset publish - -configuration Release + build.cmd -sign -publish -ci -configuration Release /p:PublishRidAgnosticPackagesFromPlatform=${{ parameters.PublishRidAgnosticPackagesFromPlatform }} + /p:DownloadDirectory=$(Build.SourcesDirectory)\artifacts\PackageDownload\ /p:OfficialBuildId=$(Build.BuildNumber) /p:SignType=$(SignType) /p:DotNetSignType=$(SignType) diff --git a/eng/pipelines/runtime-official.yml b/eng/pipelines/runtime-official.yml index 0cc897455e2e0..db129354eb7ec 100644 --- a/eng/pipelines/runtime-official.yml +++ b/eng/pipelines/runtime-official.yml @@ -589,10 +589,6 @@ extends: - SourceBuild_linux_x64 jobParameters: nameSuffix: PortableSourceBuild - postBuildSteps: - - template: /eng/pipelines/common/upload-intermediate-artifacts-step.yml - parameters: - name: SourceBuildPackages timeoutInMinutes: 95 # diff --git a/src/installer/Directory.Build.props b/src/installer/Directory.Build.props index 33a094c082f79..3e898be20b7a8 100644 --- a/src/installer/Directory.Build.props +++ b/src/installer/Directory.Build.props @@ -16,10 +16,4 @@ true - - - $([System.IO.Path]::GetDirectoryName('$(ArcadeSdkBuildTasksAssembly)'))\..\ - $(ArcadeSdkMSBuildProjectDir)Sign.proj - - diff --git a/src/installer/pkg/projects/Directory.Build.targets b/src/installer/pkg/projects/Directory.Build.targets index 74420fa76bb1f..fcb2c60b44f65 100644 --- a/src/installer/pkg/projects/Directory.Build.targets +++ b/src/installer/pkg/projects/Directory.Build.targets @@ -5,7 +5,9 @@ If we are stabilizing set the StableVersion property for the packages. Needs to happen in Directory.Build.targets to allow all the pkgproj's to set Version property first. --> - $(Version) + $(Version) - $(ProductVersion) - - - - false - true - - .sha512 - $(ArtifactsDir)PackageDownload/ - - - - - - - - - - true - - - - - - - - - true - - - - - $(SYSTEM_TEAMFOUNDATIONCOLLECTIONURI) - - - $(CollectionUri.Split('/')[3]) - - - $(CollectionUri.Split('.')[0].Split('/')[2]) - - - - - - - - - - - - - - - - - - DotNetReleaseShipping=true - - - - - - - - - - - - Manifest.xml - $(ArtifactsLogDir)AssetManifest/$(AssetManifestFilename) - - $(ProductionVersion) - $(ProductVersion) - - - - - - - - - - - - - - - - - $(InstallersRelativePath)%(Filename)%(Extension) - true - - - - $(InstallersRelativePath)%(Filename)%(Extension) - Checksum - true - - - - $(InstallersRelativePath)productVersion.txt - true - - - - $(InstallersRelativePath)runtime-productVersion.txt - true - - - - $(InstallersRelativePath)workloads/%(Filename)%(Extension) - true - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/src/installer/tests/Directory.Build.targets b/src/installer/tests/Directory.Build.targets index ecd79411081d4..9cd2ce6b9c7ed 100644 --- a/src/installer/tests/Directory.Build.targets +++ b/src/installer/tests/Directory.Build.targets @@ -37,7 +37,6 @@ diff --git a/src/mono/browser/browser.proj b/src/mono/browser/browser.proj index 38d6f035e6cf3..f412353247160 100644 --- a/src/mono/browser/browser.proj +++ b/src/mono/browser/browser.proj @@ -533,12 +533,20 @@ <_RollupInputs Include="$(BrowserProjectRoot)runtime/*.js"/> - + + + + + + <_MonoRollupEnvironmentVariable Include="Configuration:$(Configuration)" /> <_MonoRollupEnvironmentVariable Include="NativeBinDir:$(NativeBinDir)" /> <_MonoRollupEnvironmentVariable Include="WasmObjDir:$(WasmObjDir)" /> - <_MonoRollupEnvironmentVariable Include="ProductVersion:$(ProductVersion)" /> + <_MonoRollupEnvironmentVariable Include="ProductVersion:$(RuntimePackProductVersion)" /> <_MonoRollupEnvironmentVariable Include="WasmEnableThreads:$(WasmEnableThreads)" /> <_MonoRollupEnvironmentVariable Include="WASM_ENABLE_SIMD:1" Condition="'$(WasmEnableSIMD)' != 'false'" /> <_MonoRollupEnvironmentVariable Include="WASM_ENABLE_SIMD:0" Condition="'$(WasmEnableSIMD)' == 'false'" /> diff --git a/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj b/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj index 0a4927e350fe7..92c3a12bc4ce0 100644 --- a/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj +++ b/src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj @@ -24,10 +24,5 @@ - - - $(ProductVersion) - - diff --git a/src/native/corehost/corehost.proj b/src/native/corehost/corehost.proj index 026cff6928567..ab43e75f9b3e8 100644 --- a/src/native/corehost/corehost.proj +++ b/src/native/corehost/corehost.proj @@ -8,7 +8,7 @@ true - GetProductVersions;GenerateRuntimeVersionFile + GenerateRuntimeVersionFile $(BuildCoreHostDependsOn);InitializeSourceControlInformationFromSourceControlManager $(ArtifactsObjDir)$(OutputRID).$(Configuration)\ diff --git a/src/tasks/installer.tasks/GenerateChecksums.cs b/src/tasks/installer.tasks/GenerateChecksums.cs deleted file mode 100644 index f9e06415523b5..0000000000000 --- a/src/tasks/installer.tasks/GenerateChecksums.cs +++ /dev/null @@ -1,66 +0,0 @@ -// Licensed to the .NET Foundation under one or more agreements. -// The .NET Foundation licenses this file to you under the MIT license. - -using Microsoft.Build.Framework; -using System; -using System.IO; -using System.Security.Cryptography; - -namespace Microsoft.DotNet.Build.Tasks -{ - public class GenerateChecksums : BuildTask - { - /// - /// An item collection of files for which to generate checksums. Each item must have metadata - /// 'DestinationPath' that specifies the path of the checksum file to create. - /// - [Required] - public ITaskItem[] Items { get; set; } - - public override bool Execute() - { - foreach (ITaskItem item in Items) - { - try - { - string destinationPath = item.GetMetadata("DestinationPath"); - if (string.IsNullOrEmpty(destinationPath)) - { - throw new Exception($"Metadata 'DestinationPath' is missing for item '{item.ItemSpec}'."); - } - - if (!File.Exists(item.ItemSpec)) - { - throw new Exception($"The file '{item.ItemSpec}' does not exist."); - } - - Log.LogMessage( - MessageImportance.High, - "Generating checksum for '{0}' into '{1}'...", - item.ItemSpec, - destinationPath); - - using (FileStream stream = File.OpenRead(item.ItemSpec)) - { - using(HashAlgorithm hashAlgorithm = SHA512.Create()) - { - byte[] hash = hashAlgorithm.ComputeHash(stream); - string checksum = BitConverter.ToString(hash).Replace("-", string.Empty); - File.WriteAllText(destinationPath, checksum); - } - } - } - catch (Exception e) - { - // We have 2 log calls because we want a nice error message but we also want to capture the - // callstack in the log. - Log.LogError("An exception occurred while trying to generate a checksum for '{0}'.", item.ItemSpec); - Log.LogMessage(MessageImportance.Low, e.ToString()); - return false; - } - } - - return true; - } - } -}