Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][perf] iOS disk size regression on 3 Oct 2023 #93072

Closed
LeVladIonescu opened this issue Oct 5, 2023 · 7 comments
Closed

[mono][perf] iOS disk size regression on 3 Oct 2023 #93072

LeVladIonescu opened this issue Oct 5, 2023 · 7 comments
Assignees
@matouskozak
Labels
area-Codegen-AOT-mono os-ios Apple iOS size-reduction Issues impacting final app size primary for size sensitive workloads
Milestone
Future

Comments

@LeVladIonescu
Copy link
Contributor

LeVladIonescu commented Oct 5, 2023 •
edited
Loading

Description

Disk size (SOD) regressions detected in HelloiOS app for both llvm and nollvm configurations.

Details

Date Diff Change Size increase (bytes) Size increase (%)
3 Oct 2023 88f2547...d2e24fa #90764 1066800 5,01

273588138-a8439c5e-2f14-4ddc-b9a3-f32cf8d7427a

Steps to get the app sizes

  1. git checkout b9e01455c2247454ec0301b8465f7168eebd6a09 (checkout to our commit's parent)
  2. cd src/mono/sample/iOS
  3. sudo make runtimepack TARGET=iossimulator MONO_ARCH=arm64 MONO_CONFIG=Release (build the runtime)
  4. sudo make run-sim MONO_CONFIG=Release MONO_ARCH=arm64 (build the app bundle)
  5. ls -la bin/iossimulator-arm64/Bundle/HelloiOS/Release-iphonesimulator/HelloiOS.app (the app to look for is HelloiOS)
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 5, 2023
@ghost
Copy link

ghost commented Oct 5, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Disk size (SOD) regressions detected in HelloiOS app for both llvm and nollvm configurations.

Details - TBD

Date Diff Change Size increase (bytes) Size increase (%)
3 Oct 2023
Author: LeVladIonescu
Assignees: matouskozak
Labels:

untriaged, area-Codegen-JIT-mono, area-Codegen-AOT-mono, os-ios
Milestone: -

@LeVladIonescu LeVladIonescu added size-reduction Issues impacting final app size primary for size sensitive workloads and removed untriaged New issue has not been triaged by the area owner labels Oct 5, 2023
@ghost
Copy link

ghost commented Oct 5, 2023

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Disk size (SOD) regressions detected in HelloiOS app for both llvm and nollvm configurations.

Details - TBD

Date Diff Change Size increase (bytes) Size increase (%)
3 Oct 2023
Author: LeVladIonescu
Assignees: matouskozak
Labels:

area-Codegen-AOT-mono, os-ios, size-reduction
Milestone: -

@SamMonoRT SamMonoRT added this to the 9.0.0 milestone Oct 9, 2023
@SamMonoRT
Copy link
Member

Regression as seen in https://msit.powerbi.com/groups/me/apps/54e0e83f-07bc-45bf-87b7-a7677ff3af2a/reports/161e76f5-dad3-4b78-b4d2-56db2da6bdc4/ReportSectionc6d3e2c09b9adee234d0?experience=power-bi

image

@MichalPetryka
Copy link
Contributor

Could this be #90764?

@matouskozak
Copy link
Member

Could this be #90764?

@MichalPetryka we think so, but we don't have confirmation yet. @LeVladIonescu any update on reproducing the regression with said commit?

@LeVladIonescu
Copy link
Contributor Author

I've got locally the results showing the size increase after #90764.

@LeVladIonescu LeVladIonescu mentioned this issue Oct 11, 2023
Closed
@jkotas jkotas mentioned this issue Nov 3, 2023
Open
@matouskozak matouskozak mentioned this issue Dec 20, 2023
Closed
@matouskozak matouskozak mentioned this issue Feb 15, 2024
Open
@matouskozak matouskozak modified the milestones: 9.0.0, Future Feb 15, 2024
@matouskozak matouskozak mentioned this issue Jul 30, 2024
Open
@matouskozak
Copy link
Member

matouskozak commented Jul 30, 2024 •
edited
Loading

Closing in favor of #105701, feel free to re-open if you think this issue requires a separate attention.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matouskozak matouskozak

Labels
area-Codegen-AOT-mono os-ios Apple iOS size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@MichalPetryka @SamMonoRT @matouskozak @LeVladIonescu