Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreCLR test infra: improve "Skip" messages for tests blocked in issues.targets #91562

Closed
trylek opened this issue Sep 4, 2023 · 1 comment · Fixed by #93492
Closed

CoreCLR test infra: improve "Skip" messages for tests blocked in issues.targets #91562

trylek opened this issue Sep 4, 2023 · 1 comment · Fixed by #93492
Assignees
Labels
area-Infrastructure-coreclr in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@trylek
Copy link
Member

trylek commented Sep 4, 2023

Assume a test under the merged system is blocked with an issue using the file:

src/tests/issues.targets

Today, the infrastructure ends up with the following snippet in the xml log:

<test name="baseservices\threading\regressions\2164\foreground-shutdown\foreground-shutdown.cmd" type="OutOfProcessTest" method="baseservices\threading\regressions\2164\foreground-shutdown\foreground-shutdown.cmd" time="0.000000" result="Skip">
    <![CDATA[No Known Skip Reason]]></reason>
</test>

corresponding to the following section in the issues.targets file:

        <ExcludeList Include="$(XunitTestBinBase)/baseservices/threading/regressions/2164/foreground-shutdown/*">
            <Issue>https://github.com/dotnet/runtime/issues/84006</Issue>
        </ExcludeList>

I believe we should fix the merged wrapper generator support code and test
build scripts to somehow transport the reasoning string from the issues.targets
file to the output log to make it easier to understand the skip reasons.

Thanks

Tomas

/cc @dotnet/runtime-infrastructure @jkoritzinsky

@trylek trylek added this to the 9.0.0 milestone Sep 4, 2023
@ghost
Copy link

ghost commented Sep 4, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Assume a test under the merged system is blocked with an issue using the file:

src/tests/issues.targets

Today, the infrastructure ends up with the following snippet in the xml log:


corresponding to the following section in the issues.targets file:

        <ExcludeList Include="$(XunitTestBinBase)/baseservices/threading/regressions/2164/foreground-shutdown/*">
            <Issue>https://github.com/dotnet/runtime/issues/84006</Issue>
        </ExcludeList>

I believe we should fix the merged wrapper generator support code and test
build scripts to somehow transport the reasoning string from the issues.targets
file to the output log to make it easier to understand the skip reasons.

Thanks

Tomas

/cc @dotnet/runtime-infrastructure @jkoritzinsky

Author: trylek
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: 9.0.0

@ivdiazsa ivdiazsa self-assigned this Sep 27, 2023
@ivdiazsa ivdiazsa added the in-pr There is an active PR which will close this issue when it is merged label Oct 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr in-pr There is an active PR which will close this issue when it is merged
Projects
Development

Successfully merging a pull request may close this issue.

2 participants