Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Refactor System.Linq.Expressions private feature switches #89171

Closed
Tracked by #87924
ivanpovazan opened this issue Jul 19, 2023 · 1 comment · Fixed by #89308
Closed
Tracked by #87924

[NativeAOT] Refactor System.Linq.Expressions private feature switches #89171

ivanpovazan opened this issue Jul 19, 2023 · 1 comment · Fixed by #89308
Assignees
@ivanpovazan
Labels
area-NativeAOT-coreclr
Milestone
8.0.0

Comments

@ivanpovazan
Copy link
Member

ivanpovazan commented Jul 19, 2023 •
edited
Loading

Based on the comments:

Private feature switches:

  • CanCompileToIL and
  • CanCreateArbitraryDelegates

are not needed anymore as they got replaced by IsDynamicCodeSupported

Additionally:

  • CanEmitObjectArrayDelegate

should be set in RuntimeHostConfigurationOption by build integration targets, instead of explicitly passing the switch to ILC, so other tools (ILLink) can also understand the desired trimming configuration.
@ivanpovazan ivanpovazan mentioned this issue Jul 19, 2023
Closed
7 tasks
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 19, 2023
@ghost
Copy link

ghost commented Jul 19, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ivanpovazan
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@ivanpovazan ivanpovazan removed the untriaged New issue has not been triaged by the area owner label Jul 19, 2023
@ivanpovazan ivanpovazan self-assigned this Jul 19, 2023
@ivanpovazan ivanpovazan added this to the 8.0.0 milestone Jul 19, 2023
@ivanpovazan ivanpovazan mentioned this issue Jul 21, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 21, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ivanpovazan ivanpovazan

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[NativeAOT] Refactor System.Linq.Expressions feature switches ivanpovazan/runtime
1 participant
@ivanpovazan