Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: runtime-ioslike-coreclr, and runtime-ioslike-mono running on unrelated PRs #88995

Closed
radical opened this issue Jul 17, 2023 · 2 comments
Closed
Assignees
Milestone

Comments

@radical
Copy link
Member

radical commented Jul 17, 2023

New pipelines - runtime-ioslike-coreclr, and runtime-ioslike-mono were added in #87260 . But they are missing any conditions for running, which means they run on PRs with no related changes.
For example on a wasm-only PR, like #88980 .

We control the jobs running on wasm-only PRs tightly through conditions based on path triggers in eng/pipelines/common/evaluate-default-paths.yml. Similar checks, and conditions can be used for the new pipelines too. Or at least to not trigger in case for wasm-only PRs. I can also help with picking the conditions for this.

cc @kotlarmilos @steveisok @lewing

@radical radical added this to the 8.0.0 milestone Jul 17, 2023
@ghost
Copy link

ghost commented Jul 17, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

New pipelines - runtime-ioslike-coreclr, and runtime-ioslike-mono were added in #87260 . But they are missing any conditions for running, which means they run on PRs with no related changes.
For example on a wasm-only PR, like #88980 .

We control the jobs running on wasm-only PRs tightly through conditions based on path triggers in eng/pipelines/common/evaluate-default-paths.yml. Similar checks, and conditions can be used for the new pipelines too. Or at least to not trigger in case for wasm-only PRs. I can also help with picking the conditions for this.

cc @kotlarmilos @steveisok @lewing

Author: radical
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: 8.0.0

@kotlarmilos kotlarmilos self-assigned this Jul 17, 2023
@kotlarmilos
Copy link
Member

@radical Thanks for reporting the issue. The pipelines have been disabled and removed in #88999.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants