-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blazor shouldn't enable debugging when not debugging #87178
Comments
dotnet.generated.invalid is normal, it's the JS interop binding glue. the issue here is jiterpreter being missing. |
I see "Debugging hotkey: ..." when starting a sample with 'Start Without Debugging' from Visual Studio, which suggests that the interpreter is being launched with debugging enabled. If debugging is enabled that would block the jiterpreter. Examining the jiterpreter configuration indicates that it is still enabled. |
Looking at the blazor.boot.json sent over the wire when running via this path, i see "debugBuild": true even though VS is set to Release. |
https://github.com/dotnet/aspnetcore/blob/4038965d69c30f0977e112ba312c68627437ea37/src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts#L218 appears to suggest that as things are configured by blazor right now, debugging is always active so the jiterpreter will not engaged (this is required for correctness). Let me know if I'm misreading the code and I can dig in further. |
Editing the boot json to disable debugBuild and remove the pdbs (if there are any pdbs, it forces debugging on) causes the jiterpreter to engage as expected, and this appears to improve performance significantly. 👍 |
Thanks for contacting us. We're moving this issue to the |
@lewing now that the runtime will be handling the boot process for Blazor, is this something that you will be taking care of? |
@kg has this been addressed as part of the SDK changes? |
Not yet, code about resolving whether debugging is enabled, printing the message to console, etc stills need consolidation. I'll assign myself as the changes should end in the runtime codebase |
@maraf should I just move this to the runtime repo then? |
It can be moved. Changes need to happen in both repositories. |
Tagging subscribers to this area: @thaystg Issue DetailsWith .NET 8 Preview 3, I’m seeing the following dotnet.generated.invalid node show up in the sources tab of the browser dev tools when running a new Blazor WebAssembly app: I don't see any other errors in the browser dev console. Repro steps:
Expected result:
Actual result:
|
With .NET 8 Preview 3, I’m seeing the following dotnet.generated.invalid node show up in the sources tab of the browser dev tools when running a new Blazor WebAssembly app:
I don't see any other errors in the browser dev console.
Repro steps:
dotnet new blazorwasm
dotnet run
Expected result:
Actual result:
The text was updated successfully, but these errors were encountered: