Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several XML tests are sporadically failing in CI due to OOMs #82894

Closed
stephentoub opened this issue Mar 2, 2023 · 3 comments
Closed

Several XML tests are sporadically failing in CI due to OOMs #82894

stephentoub opened this issue Mar 2, 2023 · 3 comments
Labels
area-System.Xml blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab test-bug Problem in test source code (most likely)
Milestone
9.0.0

Comments

@stephentoub
Copy link
Member

stephentoub commented Mar 2, 2023 •
edited by build-analysis bot
Loading

e.g.

  Discovering: System.Private.Xml.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Private.Xml.Tests (found 4736 of 4787 test cases)
  Starting:    System.Private.Xml.Tests (parallel test collections = on, max threads = 2)
    System.Xml.CharCheckingReaderTests.CharCheckingReaderTest.RunTests(testCase: ReadBinHex runs into an Overflow) [FAIL]
      System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
      Stack Trace:
        /_/src/libraries/System.Private.CoreLib/src/System/String.cs(291,0): at System.String.Ctor(ReadOnlySpan`1 value)
        /_/src/libraries/System.Private.CoreLib/src/System/Span.cs(384,0): at System.Span`1.ToString()
        /_/src/libraries/Common/src/System/Text/ValueStringBuilder.cs(90,0): at System.Text.ValueStringBuilder.ToString()
        /_/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs(551,0): at System.String.FormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
        /_/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs(512,0): at System.String.Format(String format, Object[] args)
        /_/src/libraries/System.Private.Xml/src/System/Xml/XmlException.cs(197,0): at System.Xml.XmlException.CreateMessage(String res, String[] args, Int32 lineNumber, Int32 linePosition)
        /_/src/libraries/System.Private.Xml/src/System/Xml/XmlException.cs(117,0): at System.Xml.XmlException..ctor(String res, String arg)
        /_/src/libraries/System.Private.Xml/src/System/Xml/BinHexDecoder.cs(165,0): at System.Xml.BinHexDecoder.Decode(ReadOnlySpan`1 chars, Span`1 bytes, Boolean& hasHalfByteCached, Byte& cachedHalfByte, Int32& charsDecoded, Int32& bytesDecoded)
        /_/src/libraries/System.Private.Xml/src/System/Xml/BinHexDecoder.cs(74,0): at System.Xml.BinHexDecoder.Decode(String str, Int32 startPos, Int32 len)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(367,0): at System.Xml.ReadContentAsBinaryHelper.ReadContentAsBinary(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(394,0): at System.Xml.ReadContentAsBinaryHelper.ReadElementContentAsBinary(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(232,0): at System.Xml.ReadContentAsBinaryHelper.ReadElementContentAsBinHex(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlCharCheckingReader.cs(567,0): at System.Xml.XmlCharCheckingReader.ReadElementContentAsBinHex(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/tests/XmlReaderLib/CDataReader.cs(822,0): at System.Xml.Tests.CDataReader.ReadElementContentAsBinHex(Byte[] array, Int32 offset, Int32 len)
        /_/src/libraries/System.Private.Xml/tests/XmlReaderLib/ReadBinHex.cs(970,0): at System.Xml.Tests.TCReadElementContentAsBinHex.TestReadBinHex_105376()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/cvariation.cs(77,0): at OLEDB.Test.ModuleCore.CVariation.Execute()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/ctestcase.cs(131,0): at OLEDB.Test.ModuleCore.CTestCase.<>c__DisplayClass7_1.<TestCases>b__0()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/XunitTestCase.cs(33,0): at OLEDB.Test.ModuleCore.XunitTestCase.Run()
        /_/src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs(16,0): at System.Xml.CharCheckingReaderTests.CharCheckingReaderTest.RunTests(XunitTestCase testCase)
           at InvokeStub_CharCheckingReaderTest.RunTests(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
    System.Xml.CharCheckingReaderTests.CharCheckingReaderTest.RunTests(testCase: ReadBinHex runs into an Overflow) [FAIL]
      System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
      Stack Trace:
           at System.GC.AllocateNewArray(IntPtr typeHandle, Int32 length, GC_ALLOC_FLAGS flags)
        /_/src/libraries/System.Private.CoreLib/src/System/Buffers/TlsOverPerCoreLockedStacksArrayPool.cs(113,0): at System.Buffers.TlsOverPerCoreLockedStacksArrayPool`1.Rent(Int32 minimumLength)
        /_/src/libraries/Common/src/System/Text/ValueStringBuilder.cs(302,0): at System.Text.ValueStringBuilder.Grow(Int32 additionalCapacityBeyondPos)
        /_/src/libraries/System.Private.CoreLib/src/System/Text/ValueStringBuilder.AppendFormat.cs(250,0): at System.Text.ValueStringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
        /_/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs(550,0): at System.String.FormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
        /_/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs(512,0): at System.String.Format(String format, Object[] args)
        /_/src/libraries/System.Private.Xml/src/System/Xml/XmlException.cs(197,0): at System.Xml.XmlException.CreateMessage(String res, String[] args, Int32 lineNumber, Int32 linePosition)
        /_/src/libraries/System.Private.Xml/src/System/Xml/XmlException.cs(117,0): at System.Xml.XmlException..ctor(String res, String arg)
        /_/src/libraries/System.Private.Xml/src/System/Xml/BinHexDecoder.cs(165,0): at System.Xml.BinHexDecoder.Decode(ReadOnlySpan`1 chars, Span`1 bytes, Boolean& hasHalfByteCached, Byte& cachedHalfByte, Int32& charsDecoded, Int32& bytesDecoded)
        /_/src/libraries/System.Private.Xml/src/System/Xml/BinHexDecoder.cs(74,0): at System.Xml.BinHexDecoder.Decode(String str, Int32 startPos, Int32 len)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(367,0): at System.Xml.ReadContentAsBinaryHelper.ReadContentAsBinary(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(394,0): at System.Xml.ReadContentAsBinaryHelper.ReadElementContentAsBinary(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(232,0): at System.Xml.ReadContentAsBinaryHelper.ReadElementContentAsBinHex(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlCharCheckingReader.cs(567,0): at System.Xml.XmlCharCheckingReader.ReadElementContentAsBinHex(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/tests/XmlReaderLib/CDataReader.cs(822,0): at System.Xml.Tests.CDataReader.ReadElementContentAsBinHex(Byte[] array, Int32 offset, Int32 len)
        /_/src/libraries/System.Private.Xml/tests/XmlReaderLib/ReadBinHex.cs(970,0): at System.Xml.Tests.TCReadElementContentAsBinHex.TestReadBinHex_105376()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/cvariation.cs(77,0): at OLEDB.Test.ModuleCore.CVariation.Execute()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/ctestcase.cs(131,0): at OLEDB.Test.ModuleCore.CTestCase.<>c__DisplayClass7_1.<TestCases>b__0()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/XunitTestCase.cs(33,0): at OLEDB.Test.ModuleCore.XunitTestCase.Run()
        /_/src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs(16,0): at System.Xml.CharCheckingReaderTests.CharCheckingReaderTest.RunTests(XunitTestCase testCase)
           at InvokeStub_CharCheckingReaderTest.RunTests(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Known Issue Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "ReadBinHex runs into an Overflow",
  "BuildRetry": false
}

Report

Build Definition Test Pull Request
493122 dotnet/runtime WasmTestOnBrowser-System.Private.Xml.Tests.WorkItemExecution #95324
488999 dotnet/runtime WasmTestOnBrowser-System.Private.Xml.Tests.WorkItemExecution #95324
487764 dotnet/runtime WasmTestOnBrowser-System.Private.Xml.Tests.WorkItemExecution #95324
486016 dotnet/runtime WasmTestOnNodeJS-System.Private.Xml.Tests.WorkItemExecution #95324

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 4

Known issue validation

Build: 🔎
Result validation: ⚠️ Validation could not be done without an Azure DevOps build URL on the issue. Please add it to the "Build: 🔎" line.
@stephentoub stephentoub added area-System.Xml test-bug Problem in test source code (most likely) blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Mar 2, 2023
@stephentoub stephentoub added this to the 8.0.0 milestone Mar 2, 2023
@ghost
Copy link

ghost commented Mar 2, 2023

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

e.g.

  Discovering: System.Private.Xml.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Private.Xml.Tests (found 4736 of 4787 test cases)
  Starting:    System.Private.Xml.Tests (parallel test collections = on, max threads = 2)
    System.Xml.CharCheckingReaderTests.CharCheckingReaderTest.RunTests(testCase: ReadBinHex runs into an Overflow) [FAIL]
      System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
      Stack Trace:
        /_/src/libraries/System.Private.CoreLib/src/System/String.cs(291,0): at System.String.Ctor(ReadOnlySpan`1 value)
        /_/src/libraries/System.Private.CoreLib/src/System/Span.cs(384,0): at System.Span`1.ToString()
        /_/src/libraries/Common/src/System/Text/ValueStringBuilder.cs(90,0): at System.Text.ValueStringBuilder.ToString()
        /_/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs(551,0): at System.String.FormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
        /_/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs(512,0): at System.String.Format(String format, Object[] args)
        /_/src/libraries/System.Private.Xml/src/System/Xml/XmlException.cs(197,0): at System.Xml.XmlException.CreateMessage(String res, String[] args, Int32 lineNumber, Int32 linePosition)
        /_/src/libraries/System.Private.Xml/src/System/Xml/XmlException.cs(117,0): at System.Xml.XmlException..ctor(String res, String arg)
        /_/src/libraries/System.Private.Xml/src/System/Xml/BinHexDecoder.cs(165,0): at System.Xml.BinHexDecoder.Decode(ReadOnlySpan`1 chars, Span`1 bytes, Boolean& hasHalfByteCached, Byte& cachedHalfByte, Int32& charsDecoded, Int32& bytesDecoded)
        /_/src/libraries/System.Private.Xml/src/System/Xml/BinHexDecoder.cs(74,0): at System.Xml.BinHexDecoder.Decode(String str, Int32 startPos, Int32 len)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(367,0): at System.Xml.ReadContentAsBinaryHelper.ReadContentAsBinary(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(394,0): at System.Xml.ReadContentAsBinaryHelper.ReadElementContentAsBinary(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(232,0): at System.Xml.ReadContentAsBinaryHelper.ReadElementContentAsBinHex(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlCharCheckingReader.cs(567,0): at System.Xml.XmlCharCheckingReader.ReadElementContentAsBinHex(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/tests/XmlReaderLib/CDataReader.cs(822,0): at System.Xml.Tests.CDataReader.ReadElementContentAsBinHex(Byte[] array, Int32 offset, Int32 len)
        /_/src/libraries/System.Private.Xml/tests/XmlReaderLib/ReadBinHex.cs(970,0): at System.Xml.Tests.TCReadElementContentAsBinHex.TestReadBinHex_105376()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/cvariation.cs(77,0): at OLEDB.Test.ModuleCore.CVariation.Execute()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/ctestcase.cs(131,0): at OLEDB.Test.ModuleCore.CTestCase.<>c__DisplayClass7_1.<TestCases>b__0()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/XunitTestCase.cs(33,0): at OLEDB.Test.ModuleCore.XunitTestCase.Run()
        /_/src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs(16,0): at System.Xml.CharCheckingReaderTests.CharCheckingReaderTest.RunTests(XunitTestCase testCase)
           at InvokeStub_CharCheckingReaderTest.RunTests(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
    System.Xml.CharCheckingReaderTests.CharCheckingReaderTest.RunTests(testCase: ReadBinHex runs into an Overflow) [FAIL]
      System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
      Stack Trace:
           at System.GC.AllocateNewArray(IntPtr typeHandle, Int32 length, GC_ALLOC_FLAGS flags)
        /_/src/libraries/System.Private.CoreLib/src/System/Buffers/TlsOverPerCoreLockedStacksArrayPool.cs(113,0): at System.Buffers.TlsOverPerCoreLockedStacksArrayPool`1.Rent(Int32 minimumLength)
        /_/src/libraries/Common/src/System/Text/ValueStringBuilder.cs(302,0): at System.Text.ValueStringBuilder.Grow(Int32 additionalCapacityBeyondPos)
        /_/src/libraries/System.Private.CoreLib/src/System/Text/ValueStringBuilder.AppendFormat.cs(250,0): at System.Text.ValueStringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
        /_/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs(550,0): at System.String.FormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
        /_/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs(512,0): at System.String.Format(String format, Object[] args)
        /_/src/libraries/System.Private.Xml/src/System/Xml/XmlException.cs(197,0): at System.Xml.XmlException.CreateMessage(String res, String[] args, Int32 lineNumber, Int32 linePosition)
        /_/src/libraries/System.Private.Xml/src/System/Xml/XmlException.cs(117,0): at System.Xml.XmlException..ctor(String res, String arg)
        /_/src/libraries/System.Private.Xml/src/System/Xml/BinHexDecoder.cs(165,0): at System.Xml.BinHexDecoder.Decode(ReadOnlySpan`1 chars, Span`1 bytes, Boolean& hasHalfByteCached, Byte& cachedHalfByte, Int32& charsDecoded, Int32& bytesDecoded)
        /_/src/libraries/System.Private.Xml/src/System/Xml/BinHexDecoder.cs(74,0): at System.Xml.BinHexDecoder.Decode(String str, Int32 startPos, Int32 len)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(367,0): at System.Xml.ReadContentAsBinaryHelper.ReadContentAsBinary(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(394,0): at System.Xml.ReadContentAsBinaryHelper.ReadElementContentAsBinary(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/ReadContentAsBinaryHelper.cs(232,0): at System.Xml.ReadContentAsBinaryHelper.ReadElementContentAsBinHex(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlCharCheckingReader.cs(567,0): at System.Xml.XmlCharCheckingReader.ReadElementContentAsBinHex(Byte[] buffer, Int32 index, Int32 count)
        /_/src/libraries/System.Private.Xml/tests/XmlReaderLib/CDataReader.cs(822,0): at System.Xml.Tests.CDataReader.ReadElementContentAsBinHex(Byte[] array, Int32 offset, Int32 len)
        /_/src/libraries/System.Private.Xml/tests/XmlReaderLib/ReadBinHex.cs(970,0): at System.Xml.Tests.TCReadElementContentAsBinHex.TestReadBinHex_105376()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/cvariation.cs(77,0): at OLEDB.Test.ModuleCore.CVariation.Execute()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/ctestcase.cs(131,0): at OLEDB.Test.ModuleCore.CTestCase.<>c__DisplayClass7_1.<TestCases>b__0()
        /_/src/libraries/Common/tests/System/Xml/ModuleCore/XunitTestCase.cs(33,0): at OLEDB.Test.ModuleCore.XunitTestCase.Run()
        /_/src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs(16,0): at System.Xml.CharCheckingReaderTests.CharCheckingReaderTest.RunTests(XunitTestCase testCase)
           at InvokeStub_CharCheckingReaderTest.RunTests(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
Author: stephentoub
Assignees: -
Labels:

area-System.Xml, test-bug, blocking-clean-ci, Known Build Error
Milestone: 8.0.0

@danmoseley
Copy link
Member

ErrorMessage": "",

Won't this match every failure everywhere?

@stephentoub
Copy link
Member Author

Won't this match every failure everywhere?

The bot added that. I haven't yet edited it.

@ManickaP ManickaP mentioned this issue Apr 21, 2023
Merged
@eiriktsarpalis eiriktsarpalis modified the milestones: 8.0.0, Future Aug 1, 2023
@build-analysis build-analysis bot removed this from the Future milestone Nov 15, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 15, 2023
@jeffhandley jeffhandley added this to the 9.0.0 milestone Nov 17, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 17, 2023
@stephentoub stephentoub closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Xml blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
4 participants
@jeffhandley @stephentoub @eiriktsarpalis @danmoseley