Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed '!varTypeUsesFloatReg(targetType) || (emitTypeSize(targetType) == emitTypeSize(op1Type))' #80773

Closed
BruceForstall opened this issue Jan 18, 2023 · 4 comments
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes Priority:1 Work that is critical for the release, but we could probably ship without
Milestone

Comments

@BruceForstall
Copy link
Member

Failure in System.Numerics.Vectors.Tests in many variations of runtime-coreclr libraries-jitstress pipeline.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=140597&view=ms.vss-test-web.build-test-results-tab&runId=3049944&resultId=199871&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

Assert failure(PID 4676 [0x00001244], Thread: 4260 [0x10a4]): Assertion failed '!varTypeUsesFloatReg(targetType) || (emitTypeSize(targetType) == emitTypeSize(op1Type))' in 'System.Numerics.Tests.Matrix3x2Tests:Matrix3x2EqualsNaNTest():this' during 'Generate code' (IL size 763; hash 0xd96aa0b9; FullOpts)

    File: D:\a\_work\1\s\src\coreclr\jit\codegenxarch.cpp Line: 4927
    Image: C:\h\w\9E2F091C\p\dotnet.exe

@dotnet/jit-contrib

@BruceForstall BruceForstall added JitStress CLR JIT issues involving JIT internal stress modes area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs labels Jan 18, 2023
@BruceForstall BruceForstall added this to the 8.0.0 milestone Jan 18, 2023
@ghost
Copy link

ghost commented Jan 18, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Failure in System.Numerics.Vectors.Tests in many variations of runtime-coreclr libraries-jitstress pipeline.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=140597&view=ms.vss-test-web.build-test-results-tab&runId=3049944&resultId=199871&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

Assert failure(PID 4676 [0x00001244], Thread: 4260 [0x10a4]): Assertion failed '!varTypeUsesFloatReg(targetType) || (emitTypeSize(targetType) == emitTypeSize(op1Type))' in 'System.Numerics.Tests.Matrix3x2Tests:Matrix3x2EqualsNaNTest():this' during 'Generate code' (IL size 763; hash 0xd96aa0b9; FullOpts)

    File: D:\a\_work\1\s\src\coreclr\jit\codegenxarch.cpp Line: 4927
    Image: C:\h\w\9E2F091C\p\dotnet.exe

@dotnet/jit-contrib

Author: BruceForstall
Assignees: -
Labels:

JitStress, area-CodeGen-coreclr, blocking-clean-ci-optional

Milestone: 8.0.0

@JulieLeeMSFT
Copy link
Member

Assigned to @TIHan for assert in Code Gen.
CC @dotnet/jit-contrib.

@tannergooding
Copy link
Member

The first run I see this in is https://dev.azure.com/dnceng-public/public/_build/results?buildId=138109&view=results which corresponds to my PR #80626

Notably I had run jitstress, but not the libraries-jitstress variant, just the outerloop, isas-x86, and isas-x64. I'm guessing there is some edge case that is only covered by libraries tests atm.

@JulieLeeMSFT JulieLeeMSFT added the Priority:1 Work that is critical for the release, but we could probably ship without label Jan 23, 2023
@TIHan
Copy link
Contributor

TIHan commented Jan 23, 2023

I have a minimal repo so far:

Matrix3x2 a = new Matrix3x2(float.NaN, 0, 0, 0, 0, 0);
Assert.False(a.Equals(new Matrix3x2()));

@TIHan TIHan closed this as completed Jan 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Development

No branches or pull requests

4 participants