Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msquic to 2.1.1 #75262

Closed
20 of 26 tasks
karelz opened this issue Sep 8, 2022 · 11 comments
Closed
20 of 26 tasks

Update msquic to 2.1.1 #75262

karelz opened this issue Sep 8, 2022 · 11 comments
Assignees
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@karelz
Copy link
Member

karelz commented Sep 8, 2022

New servicing release for msquic 2.1.1 - https://github.com/microsoft/msquic/releases/tag/v2.1.1
Contains:

We need to:

@wfurt is that all? I would like to document complete list of things that have to happen to consume new msquic release for future usage.

@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions area-System.Net.Quic labels Sep 8, 2022
@karelz karelz added this to the 7.0.0 milestone Sep 8, 2022
@ghost
Copy link

ghost commented Sep 8, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

New servicing release for msquic 2.1.1 - https://github.com/microsoft/msquic/releases/tag/v2.1.1
Contains:

We need to:

  • Update Docker images for testing (TODO: List all Docker images we need to change and the PRs)
  • Update sources used for Windows runtime build

@wfurt is that all? I would like to document complete list of things that have to happen to consume new msquic release for future usage.

Author: karelz
Assignees: -
Labels:

enhancement, area-System.Net.Quic

Milestone: 7.0.0

@wfurt wfurt self-assigned this Sep 8, 2022
@wfurt

This comment was marked as duplicate.

@wfurt

This comment was marked as duplicate.

@wfurt

This comment was marked as duplicate.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 12, 2022
@rzikm
Copy link
Member

rzikm commented Sep 13, 2022

Docker images currently in use on main (taken from https://github.com/dotnet/runtime/blob/main/eng/pipelines/libraries/helix-queues-setup.yml). Checked items are tracked in the post above.

Arm32v7:

Arm32v6:

Arm64v8:

x64 musl:

x64:

@rzikm
Copy link
Member

rzikm commented Sep 13, 2022

@wfurt I noticed you updated the image for Fedora 36, but that image is not used (at least on main), should we add it?

@wfurt
Copy link
Member

wfurt commented Sep 13, 2022

We will need to switch to msquic/main at some point during 8.0 development. One good way how to do that is do that on upgraded OS e.g. keep 34+2.1.1 as legacy and move runtime/main to 36+msquic/main. That would give us most of the coverage IMHO.

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 14, 2022
@karelz
Copy link
Member Author

karelz commented Sep 14, 2022

Thanks @rzikm for the Docker image list!
Comments on missing images:

Image Notes
Raspbian.10.Armv6.Open No officially supported by .NET 7.0, ok to skip for now
Alpine.314.Amd64.Open Blocked on official msquic release for Alpine
Alpine.313.Amd64.Open Blocked on official msquic release for Alpine
Centos.7.Amd64.Open Not supported - the image does not have minimal OpenSSL 1.1.1 required for msquic
Mariner.1.0.Amd64.Open Not officially supported by .NET 7.0, ok to skip for now

@wfurt
Copy link
Member

wfurt commented Sep 14, 2022

dotnet/dotnet-buildtools-prereqs-docker#692 for the Alpine. We can run 2.1.1 binaries we can build our ourselves.
3.13 is end of support in November, we should kick it out and perhaps test on 3.16 as current latest stable release.

@karelz
Copy link
Member Author

karelz commented Sep 14, 2022

We are done here for 7.0 in dotnet/runtime repo. The 2 remaining work items for 7.0:

@karelz
Copy link
Member Author

karelz commented Sep 14, 2022

Fixed in main (8.0) in PRs #75287, #75291, #75380 and #75534.
Fixed in 7.0 (RC2) in PR #75479

@karelz karelz closed this as completed Sep 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

3 participants