[API Proposal]: Make RateLimitPartition.Factory public

[wtgodbe]

Background and motivation

This will allow aspnetcore's RateLimitingMiddleware to resolve a Limiter from a given TKey without having to use reflection. The use case is that users provide a Func<HttpContext, RateLimitPartition<TKey>>, which we want to convert to a Func<HttpContext, RateLimitPartition<AspNetKey<TKey>>> (using Factory) - AspNetKey being used to remove possible ambiguities between TKeys.

API Proposal

namespace System.Threading.RateLimiting
{
    public struct RateLimitPartition<TKey>
    {
        public RateLimitPartition(TKey partitionKey, Func<TKey, RateLimiter> factory)
        public TKey PartitionKey { get; }
+       public Func<TKey, RateLimiter> Factory {get; }
}

API Usage

RateLimiter limiter = partition.Factory("MyLimiter");

Alternative Designs

The other option is to use private reflection

Risks

N/A?

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Background and motivation

This will allow aspnetcore's RateLimitingMiddleware to resolve a Limiter from a given TKey without having to use reflection. The use case is that users provide a Func<HttpContext, RateLimitPartition<TKey>>, which we want to convert to a Func<HttpContext, RateLimitPartition<AspNetKey<TKey>>> (using Factory) - AspNetKey being used to remove possible ambiguities between TKeys.

API Proposal

namespace System.Threading.RateLimiting
{
    public struct RateLimitPartition<TKey>
    {
        public RateLimitPartition(TKey partitionKey, Func<TKey, RateLimiter> factory)
        public TKey PartitionKey { get; }
+       public Func<TKey, RateLimiter> Factory {get; }
}

API Usage

RateLimiter limiter = partition.Factory("MyLimiter");

Alternative Designs

The other option is to use private reflection

Risks

N/A?

Author:	wtgodbe
Assignees:	-
Labels:	area-System.Threading, blocking, untriaged, api-ready-for-review
Milestone:	-