Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseservices\\exceptions\\stackoverflow\\stackoverflowtester\\stackoverflowtester.cmd #65201

Closed
runfoapp bot opened this issue Feb 11, 2022 · 8 comments
Closed

Comments

@runfoapp
Copy link

runfoapp bot commented Feb 11, 2022

Example build: https://dev.azure.com/dnceng/public/_build/results?buildId=1606981&view=results

BEGIN EXECUTION
"C:\h\w\BEFD09CE\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false"  stackoverflowtester.dll 
Running stackoverflow test(smallframe main)
"Stack overflow."
"Repeat 43073 times:"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionA()"
"   at TestStackOverflow.Program.InfiniteRecursionC()"
"   at TestStackOverflow.Program.InfiniteRecursionB()"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionA()"
"   at TestStackOverflow.Program.Test(Boolean)"
"   at TestStackOverflow.Program.Main(System.String[])"
""
Running stackoverflow test(largeframe main)
"Stack overflow."
"Repeat 8 times:"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionC2()"
"   at TestStackOverflow.Program.InfiniteRecursionB2()"
"   at TestStackOverflow.Program.InfiniteRecursionA2()"
"--------------------------------"
"   at TestStackOverflow.Program.Test(Boolean)"
"   at TestStackOverflow.Program.Main(System.String[])"
""
Running stackoverflow test(smallframe secondary)
"Stack overflow."
"Repeat 43121 times:"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB()"
"   at TestStackOverflow.Program.InfiniteRecursionA()"
"   at TestStackOverflow.Program.InfiniteRecursionC()"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB()"
"   at TestStackOverflow.Program.InfiniteRecursionA()"
"   at TestStackOverflow.Program.Test(Boolean)"
"   at TestStackOverflow.Program+<>c__DisplayClass7_0.<SecondaryThreadsTest>b__0()"
"   at System.Threading.Thread.StartCallback()"
""
Exit code: 0x800703E9, expected 0xC00000FD
Expected: 100
Actual: 103
END EXECUTION - FAILED
FAILED

Runfo Tracking Issue: baseservices\exceptions\stackoverflow\stackoverflowtester\stackoverflowtester.cmd

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1858712 runtime PR 71567 coreclr windows x86 Checked no_tiered_compilation @ Windows.10.Amd64.Open console.log core dump runclient.py
1857672 runtime PR 71567 coreclr windows x86 Checked no_tiered_compilation @ Windows.10.Amd64.Open console.log core dump runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 2
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Diagnostics-coreclr untriaged New issue has not been triaged by the area owner labels Feb 11, 2022
@ghost
Copy link

ghost commented Feb 11, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Creating Tracking Issue (data being generated)

Author: runfoapp[bot]
Assignees: -
Labels:

area-Diagnostics-coreclr, untriaged

Milestone: -

@elinor-fung
Copy link
Member

Related: #63325

@elinor-fung
Copy link
Member

Seems like an intermittent failure.
cc @janvorli

@janvorli
Copy link
Member

Interestingly, the error code is ERROR_STACK_OVERFLOW, so there are two valid error codes we can get for stack overflow probably depending on where it stemmed from.
I'll update the test to allow both of the codes. In fact, I think I've seen that in the past and that I was already handling both of them.

@BruceForstall BruceForstall added this to the 7.0.0 milestone Feb 22, 2022
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Feb 22, 2022
@janvorli
Copy link
Member

@BruceForstall this is a different issue from the one in the title (and that I have fixed already last week). Here the stack overflow fails just with StackOverflow message and no stack trace dumped. But we can repurpose this issue for it too.

@BruceForstall
Copy link
Member

I see another case of the failure:

    baseservices\exceptions\stackoverflow\stackoverflowtester\stackoverflowtester.cmd [FAIL]
      
      Return code:      1
      Raw output file:      C:\h\w\BA7409D2\w\B0520902\uploads\Reports\baseservices.exceptions\stackoverflow\stackoverflowtester\stackoverflowtester.output.txt
      Raw output:
      BEGIN EXECUTION
       "C:\h\w\BA7409D2\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false"  stackoverflowtester.dll 
      Running stackoverflow test(smallframe main)
      "Stack overflow."
      "Repeat 35230 times:"
      "--------------------------------"
      "   at TestStackOverflow.Program.InfiniteRecursionB()"
      "   at TestStackOverflow.Program.InfiniteRecursionA()"
      "   at TestStackOverflow.Program.InfiniteRecursionC()"
      "--------------------------------"
      "   at TestStackOverflow.Program.InfiniteRecursionB()"
      "   at TestStackOverflow.Program.InfiniteRecursionA()"
      "   at TestStackOverflow.Program.Test(Boolean)"
      "   at TestStackOverflow.Program.Main(System.String[])"
      ""
      Running stackoverflow test(largeframe main)
      "Stack overflow."
      "Repeat 8 times:"
      "--------------------------------"
      "   at TestStackOverflow.Program.InfiniteRecursionC2()"
      "   at TestStackOverflow.Program.InfiniteRecursionB2()"
      "   at TestStackOverflow.Program.InfiniteRecursionA2()"
      "--------------------------------"
      "   at TestStackOverflow.Program.Test(Boolean)"
      "   at TestStackOverflow.Program.Main(System.String[])"
      ""
      Running stackoverflow test(smallframe secondary)
      "Stack overflow."
      "Repeat 35297 times:"
      "--------------------------------"
      "   at TestStackOverflow.Program.InfiniteRecursionA()"
      "   at TestStackOverflow.Program.InfiniteRecursionC()"
      "   at TestStackOverflow.Program.InfiniteRecursionB()"
      "--------------------------------"
      "   at TestStackOverflow.Program.InfiniteRecursionA()"
      "   at TestStackOverflow.Program.Test(Boolean)"
      "   at TestStackOverflow.Program+<>c__DisplayClass7_0.<SecondaryThreadsTest>b__0()"
      "   at System.Threading.Thread+StartHelper.Run()"
      "   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, System.Runtime.CompilerServices.PortableTailCallFrame*), IntPtr)"
      "   at System.Threading.Thread.StartCallback()"
      ""
      Running stackoverflow test(largeframe secondary)
      "Stack overflow."
      "Repeat 8 times:"
      "--------------------------------"
      "   at TestStackOverflow.Program.InfiniteRecursionC2()"
      "   at TestStackOverflow.Program.InfiniteRecursionB2()"
      "   at TestStackOverflow.Program.InfiniteRecursionA2()"
      "--------------------------------"
      "   at TestStackOverflow.Program.Test(Boolean)"
      "   at TestStackOverflow.Program+<>c__DisplayClass7_0.<SecondaryThreadsTest>b__0()"
      "   at System.Threading.Thread+StartHelper.Run()"
      "   at System.Runtime.CompilerServices.RuntimeHelpers.DispatchTailCalls(IntPtr, Void (IntPtr, IntPtr, System.Runtime.CompilerServices.PortableTailCallFrame*), IntPtr)"
      "   at System.Threading.Thread.StartCallback()"
      ""
      Running stackoverflow3 test()
      Call number 50 to the Execute method
      Call number 100 to the Execute method
      Call number 150 to the Execute method
      "Stack overflow."
      ""
      Missing "Main" method frame at the last line
      Expected: 100
      Actual: 105
      END EXECUTION - FAILED
      FAILED

https://dev.azure.com/dnceng/public/_build/results?buildId=1737021&view=ms.vss-test-web.build-test-results-tab&runId=47017162&resultId=106165&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

A rough Kusto query shows a number of failures with different causes:

let test_name = "stackoverflowtester";
Jobs
| join WorkItems on JobId
| join TestResults on WorkItemId
| where Type1 contains test_name
  and Status <> "Pass" and (Method == "cmd" or Method == "sh")
| project Queued, Pipeline = parse_json(Properties).DefinitionName, Pipeline_Configuration = parse_json(Properties).configuration,
  OS = QueueName, Arch = parse_json(Properties).architecture, Test = Type1, Result, Duration, Console_log = Message, WorkItemFriendlyName, Method 
| order  by Queued desc

@janvorli
Copy link
Member

According to Kusto, this issue doesn't occur anymore.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants