Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Server side certificate selection via ServerCertificateSelectionCallback should work #55421

Closed
ManickaP opened this issue Jul 9, 2021 · 2 comments · Fixed by #55468
Closed

[QUIC] Server side certificate selection via ServerCertificateSelectionCallback should work #55421

ManickaP opened this issue Jul 9, 2021 · 2 comments · Fixed by #55468
Assignees
@wfurt
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Milestone
6.0.0

Comments

@ManickaP
Copy link
Member

ManickaP commented Jul 9, 2021

ServerCertificateSelectionCallback. Used for SNI. Already used as part of setting the server certificate with a listener connection. Relevent: https://github.com/microsoft/msquic/blob/73bd4a7700b9d0c4f9570a46734eb9bf40f8448f/src/inc/msquic.h#L753

Apparently, this is supported by msquic, we should add support.

Spin off #49574
@ManickaP ManickaP added this to the 6.0.0 milestone Jul 9, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net.Http untriaged New issue has not been triaged by the area owner labels Jul 9, 2021
@ghost
Copy link

ghost commented Jul 9, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

ServerCertificateSelectionCallback. Used for SNI. Already used as part of setting the server certificate with a listener connection. Relevent: https://github.com/microsoft/msquic/blob/73bd4a7700b9d0c4f9570a46734eb9bf40f8448f/src/inc/msquic.h#L753

Apparently, this is supported by msquic, we should add support.

Spin off #49574

Author: ManickaP
Assignees: wfurt
Labels:

area-System.Net.Http, untriaged
Milestone: 6.0.0

@ManickaP ManickaP added area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner area-System.Net.Http labels Jul 9, 2021
@ghost
Copy link

ghost commented Jul 9, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

ServerCertificateSelectionCallback. Used for SNI. Already used as part of setting the server certificate with a listener connection. Relevent: https://github.com/microsoft/msquic/blob/73bd4a7700b9d0c4f9570a46734eb9bf40f8448f/src/inc/msquic.h#L753

Apparently, this is supported by msquic, we should add support.

Spin off #49574

Author: ManickaP
Assignees: wfurt
Labels:

area-System.Net.Quic, enhancement
Milestone: 6.0.0

@ManickaP ManickaP mentioned this issue Jul 9, 2021
Closed
11 tasks
@wfurt wfurt mentioned this issue Jul 11, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 11, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wfurt wfurt

Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

fix SNI handling in quic wfurt/runtime
2 participants
@ManickaP @wfurt