[wasm][aot] Blazor template AOT fails in IcalTableGenerator #51195

lewing · 2021-04-13T20:52:23Z

/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018: The "IcallTableGenerator" task failed unexpectedly. [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018: System.NotImplementedException: System.Threading.Thread [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.AppendType(StringBuilder sb, Type t) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.AppendType(StringBuilder sb, Type t) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.ProcessType(Type type) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.GenIcallTable(String runtimeIcallTableFile, String[] assemblies) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.Execute() [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/Users/lewing/Source/baot/baot.csproj]

https://github.com/dotnet/runtime/blob/main/src/tasks/WasmAppBuilder/IcallTableGenerator.cs#L175

current guess is it is from

#49637

The text was updated successfully, but these errors were encountered:

ghost · 2021-04-13T20:52:26Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018: The "IcallTableGenerator" task failed unexpectedly. [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018: System.NotImplementedException: System.Threading.Thread [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.AppendType(StringBuilder sb, Type t) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.AppendType(StringBuilder sb, Type t) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.ProcessType(Type type) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.GenIcallTable(String runtimeIcallTableFile, String[] assemblies) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.Execute() [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/Users/lewing/Source/baot/baot.csproj]

https://github.com/dotnet/runtime/blob/main/src/tasks/WasmAppBuilder/IcallTableGenerator.cs#L175

current guess is it is from

#49637

Author:	lewing
Assignees:	vargaz, CoffeeFlux
Labels:	`arch-wasm`, `area-CoreLib-mono`
Milestone:	6.0.0

lewing · 2021-04-13T20:53:05Z

This is blocking AOT for preview 4

cc @pranavkm

pranavkm · 2021-04-13T21:20:21Z

FYI @mkArtakMSFT

CoffeeFlux · 2021-04-13T21:48:16Z

The result is likely this change:

-        private static extern void InitializeCurrentThread_icall([NotNull] ref Thread? thread);
+        private static extern Thread GetCurrentThread();

I'm not clear on how this worked before though? A ref type would have hit this before:

runtime/src/tasks/WasmAppBuilder/IcallTableGenerator.cs

Lines 181 to 185 in c377f41

    
           else if (t.IsByRef) 
        
           { 
        
               AppendType (sb, t.GetElementType()!); 
        
               sb.Append ('&'); 
        
           }

But then it should have tried the Thread? We also use that type in other icalls... @vargaz any ideas?

lewing · 2021-04-13T22:01:42Z

Let me check the versions here, this may be from before that pr

radical · 2021-04-13T22:44:00Z

The result is likely this change:
-        private static extern void InitializeCurrentThread_icall([NotNull] ref Thread? thread);
+        private static extern Thread GetCurrentThread();
I'm not clear on how this worked before though? A ref type would have hit this before:

runtime/src/tasks/WasmAppBuilder/IcallTableGenerator.cs

Lines 181 to 185 in c377f41

else if (t.IsByRef)

{

AppendType (sb, t.GetElementType()!);

sb.Append ('&');

}

But then it should have tried the Thread? We also use that type in other icalls... @vargaz any ideas?

AFAICS:

AppendType is not used for return types
The trace has AppendType -> AppendType
.. which would be consistent for a Thread& argument.

The change in the icall was:

        [MethodImplAttribute(MethodImplOptions.InternalCall)]
   -      private static extern void InitializeCurrentThread_icall([NotNull] ref Thread? thread);
   +      private static extern Thread GetCurrentThread();

The old one would be Thread&, and would fail with AppendType.

But, this one never really gets processed because it is already present in the table generated for the runtime.

The new one, would not be passed to AppendType at all.

So.. I think this might be a case of old runtime(or cross compiler?), and a newer System.Private.CoreLib?

Please correct me if I'm wrong! I can't reproduce it locally, so I wasn't able to confirm my hypothesis!

lewing · 2021-04-13T22:57:28Z

Yeah I think the failure may actually have been with the previous version. This was with packaged versions flowing from aspnetcore it may be working in main

lewing · 2021-04-13T23:40:43Z

I think this was actually fixed by that pr, closing for now

lewing · 2021-04-14T00:48:43Z

This is caused by a version mismatch between the runtime (set in the sdk and was blocked by dotnet/sdk#16810) and the version of the cross toolchain in the manifest.

lewing · 2021-04-14T12:52:04Z

cc @marek-safar

lewing added arch-wasm WebAssembly architecture area-CoreLib-mono labels Apr 13, 2021

lewing added this to the 6.0.0 milestone Apr 13, 2021

lewing assigned vargaz and CoffeeFlux Apr 13, 2021

dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 13, 2021

lewing added the blocking Marks issues that we want to fast track in order to unblock other important work label Apr 13, 2021

lewing closed this as completed Apr 13, 2021

lewing reopened this Apr 13, 2021

lewing closed this as completed Apr 14, 2021

ghost locked as resolved and limited conversation to collaborators May 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm][aot] Blazor template AOT fails in IcalTableGenerator #51195

[wasm][aot] Blazor template AOT fails in IcalTableGenerator #51195

lewing commented Apr 13, 2021

ghost commented Apr 13, 2021

lewing commented Apr 13, 2021

pranavkm commented Apr 13, 2021

CoffeeFlux commented Apr 13, 2021

lewing commented Apr 13, 2021

radical commented Apr 13, 2021

lewing commented Apr 13, 2021 •

edited

Loading

lewing commented Apr 13, 2021

lewing commented Apr 14, 2021

lewing commented Apr 14, 2021

[wasm][aot] Blazor template AOT fails in IcalTableGenerator #51195

[wasm][aot] Blazor template AOT fails in IcalTableGenerator #51195

Comments

lewing commented Apr 13, 2021

ghost commented Apr 13, 2021

lewing commented Apr 13, 2021

pranavkm commented Apr 13, 2021

CoffeeFlux commented Apr 13, 2021

lewing commented Apr 13, 2021

radical commented Apr 13, 2021

lewing commented Apr 13, 2021 • edited Loading

lewing commented Apr 13, 2021

lewing commented Apr 14, 2021

lewing commented Apr 14, 2021

lewing commented Apr 13, 2021 •

edited

Loading