HttpStress.csproj fails to build again

[antonfirsov]

According to the log a change between #50265 and #50244 broke the HttpStress builds:
https://dev.azure.com/dnceng/public/_build/results?buildId=1078046&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=8ca65746-3bfa-57bf-9141-d805b5d39db5

Call stack:

C:\Program Files\dotnet\sdk\5.0.202\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: The "ResolvePackageAssets" task failed unexpectedly.
System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
   at System.IO.Strategies.SyncWindowsFileStreamStrategy.Write(Byte[] buffer, Int32 offset, Int32 count) in /_/src/libraries/System.Private.CoreLib/src/System/IO/Strategies/SyncWindowsFileStreamStrategy.cs:line 64
   at System.IO.Strategies.BufferedFileStreamStrategy.Flush(Boolean flushToDisk) in /_/src/libraries/System.Private.CoreLib/src/System/IO/Strategies/BufferedFileStreamStrategy.cs:line 778
   at System.IO.Strategies.BufferedFileStreamStrategy.Dispose(Boolean disposing) in /_/src/libraries/System.Private.CoreLib/src/System/IO/Strategies/BufferedFileStreamStrategy.cs:line 167
   at System.IO.Stream.Close() in /_/src/libraries/System.Private.CoreLib/src/System/IO/Stream.cs:line 165
   at System.IO.BinaryWriter.Dispose(Boolean disposing) in /_/src/libraries/System.Private.CoreLib/src/System/IO/BinaryWriter.cs:line 75
   at System.IO.BinaryWriter.Dispose() in /_/src/libraries/System.Private.CoreLib/src/System/IO/BinaryWriter.cs:line 81
   at Microsoft.NET.Build.Tasks.ResolvePackageAssets.CacheWriter.WriteToCacheFile()
   at Microsoft.NET.Build.Tasks.ResolvePackageAssets.CacheReader.CreateReaderFromDisk(ResolvePackageAssets task, Byte[] settingsHash)
   at Microsoft.NET.Build.Tasks.ResolvePackageAssets.CacheReader..ctor(ResolvePackageAssets task)
   at Microsoft.NET.Build.Tasks.ResolvePackageAssets.ReadItemGroups()
   at Microsoft.NET.Build.Tasks.ResolvePackageAssets.ExecuteCore()
   at Microsoft.NET.Build.Tasks.TaskBase.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [C:\app\HttpStress.csproj]

@ViktorHofer any hints?

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

According to the log a change between #50265 and #50244 broke the HttpStress builds:
https://dev.azure.com/dnceng/public/_build/results?buildId=1078046&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=8ca65746-3bfa-57bf-9141-d805b5d39db5

The error we see is the following:

C:\Program Files\dotnet\sdk\5.0.202\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: The "ResolvePackageAssets" task failed unexpectedly. [C:\app\HttpStress.csproj]
C:\Program Files\dotnet\sdk\5.0.202\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. [C:\app\HttpStress.csproj]

@ViktorHofer any hints?

Author:	antonfirsov
Assignees:	-
Labels:	area-System.Net.Http, untriaged
Milestone:	-

[ViktorHofer]

Taking a look now

[ViktorHofer]

Without a binlog (which isn't produced nor uploaded) this is really hard to diagnose.

[antonfirsov]

I have a local repro. How can I get the binlog(s) that can help diagnosing this?

Here is the PR history between the last successful and the first failing CI run, in case any of them is obviously suspicious:

• [wasm] Add targets to run samples ([wasm] Add targets to run samples #50244)
• [main] Update dependencies from dotnet/runtime dotnet/arcade dotnet/icu dotnet/xharness dotnet/llvm-project ([main] Update dependencies from dotnet/runtime dotnet/arcade dotnet/icu dotnet/xharness dotnet/llvm-project #50733)
• Make ModuleTests.ResolveField/Method actually test something (Make ModuleTests.ResolveField/Method actually test something #50280)
• Disable Net5CompatFileStream by default (Disable Net5CompatFileStream by default #50166)
• Resolve ILLink warnings on System.Private.DataContractSerialization Part 1; Json) (Resolve ILLink warnings on System.Private.DataContractSerialization Part 1; Json) #50619)
• Fix handling of not found exported types (Fix handling of not found exported types #50845)
• Fix contained LCL_VAR_ADDR in RMW. (Fix contained LCL_VAR_ADDR in RMW. #50669)
• Update build-runtime.cmd help documentation (Update build-runtime.cmd help documentation #50829)
• Delete infra changes (Delete infra changes #50789)
• Fix JIT rolling build for new build-runtime script arguments (Fix JIT rolling build for new build-runtime script arguments #50876)
• [wasm] Set __DistroRid on Windows to browser-wasm ([wasm] Set __DistroRid on Windows to browser-wasm #50842)
• [wasm] Fix order of include paths, to have the obj dir first ([wasm] Fix order of include paths, to have the obj dir first #50303)
• [wasm] Fix debug build of AOT cross compiler ([wasm] Fix debug build of AOT cross compiler #50418)
• Fix outdated comment (Fix outdated comment #50834)
• [wasm][tests] Add properties to allow passing args to xharness ([wasm][tests] Add properties to allow passing args to xharness #50678)
• Vectorized common String.Split() paths (Vectorized common String.Split() paths #38001)
• Fix binplacing symbol files. (Fix binplacing symbol files. #50819)
• Move type check to after the null ref branch in out marshalling of blittable classes. (Move type check to after the null ref branch in out marshalling of blittable classes. #50735)
• Remove extraneous CMake version requirement. (Remove extraneous CMake version requirement. #50805)
• [wasm] Remove unncessary condition for EMSDK ([wasm] Remove unncessary check for EMSDK_PATH #50810)
• Add loop alignment stats to JitLogCsv (Add loop alignment stats to JitLogCsv #50624)
• Resolve ILLink warnings in System.Diagnostics.DiagnosticSource (Resolve ILLink warnings in System.Diagnostics.DiagnosticSource #50265)

[ViktorHofer]

Add /bl to the build command and send me the binlog (name by default is msbuild.binlog) via Teams please (a binlog contains env vars).

[antonfirsov]

I managed to track this to #50166 with git bisect. Setting DOTNET_SYSTEM_IO_USENET5COMPATFILESTREAM=1 fixes the issue.

#50166 might be concerning regarding the ability of using .NET 6 with dotnet build from within a Windows docker container.

/cc @adamsitnik

[antonfirsov]

I see it has been addressed in #51151, trying again with fresh main.

[antonfirsov]

#51151 fixed this, looks like an exceptional case (a library bug broke the SDK). @ViktorHofer thanks for your support!

[adamsitnik]

#51151 fixed this

@antonfirsov thank you for the confirmation!