-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed PGO auditing #50432
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
@AndyAyersMS updates the the managed pgo data are handled by dependency flow, so they are already visible as commits. Updates are visible as changes to eng/Versions.props and in particular when optimizationwindows_ntx64MIBCRuntimeVersion or the other related variables change. However, the rest of your points are quite interesting. |
@davidwrighton thanks. So I take it we have not had an update since the initial checkin, and that data was gathered on 3/17? Have you any ideas on a reasonable cadence for updates? @DrewScoggins another possibility for what we were seeing in some of those perf tests is that the FX code (at the IL level) has shifted away from what it was back on 3/17 or thereabouts, and so PGO data no longer applies. Currently we can only tell this is happening indirectly. In general if we don't update PGO data we expect to see a decline in perf over time as mismatches between what was measured and what is being prejitted or jitted become more and more pronounced. For any given test the jumps may be at particular points; if we could "integrate" all these over a lot of test we'd see more of a smooth overall degradation. |
Correct, we haven't had an update since initial checkin. @Lxiamail is working on the build so that we'll have regular flow, but the build infrastructure has proven difficult to update. Once that is up and running it should be straightforward to receive updates about once a day. |
Now that we have static managed PGO data flowing around, we need a way to track and audit the data:
COMPlus_JitDisablePgo=1
), so we cancc @davidwrighton @DrewScoggins
The text was updated successfully, but these errors were encountered: