Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark UnsafeQueueNativeOverlapped as windows only #46300

Closed
davidfowl opened this issue Dec 21, 2020 · 2 comments · Fixed by #55148
Closed

Mark UnsafeQueueNativeOverlapped as windows only #46300

davidfowl opened this issue Dec 21, 2020 · 2 comments · Fixed by #55148
Labels
area-System.Threading
Milestone
6.0.0

Comments

@davidfowl
Copy link
Member

ThreadPool.BindHandle is marked as [SupportedOSPlatform("windows")] but not ThreadPool.UnsafeQueueNativeOverlapped.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Threading untriaged New issue has not been triaged by the area owner labels Dec 21, 2020
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Jul 4, 2021
@mangod9 mangod9 added this to the 6.0.0 milestone Jul 4, 2021
@mangod9
Copy link
Member

mangod9 commented Jul 4, 2021

@davidfowl assume this was found during code review and isn't causing any issues on non-windows?

@stephentoub stephentoub mentioned this issue Jul 4, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 4, 2021
@davidfowl
Copy link
Member Author

It was just something I noticed while using the APIs.

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Threading
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix a couple missing SupportedOSPlatform attributes on ThreadPool stephentoub/runtime
3 participants
@davidfowl @Dotnet-GitSync-Bot @mangod9