-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renable SocketOptionName.ReuseUnicastPort test #15888
Comments
@davidsh Is this something that can be solved by just creating a new VM image, with the appropriate configuration, and setting up a new CI job to use that image? |
Yes. And in particular it would be good to be able to have various Windows 10 images with RTM versus other versions of Windows 10, i.e. Windows 10 RTM (build 10240) vs. TH2 (build 10586) vs. RS1 (build 14393) etc. This will enable us to do positive testing of expected features/behaviors from each release. |
Closing. We will see if we need it for more tests in future - then we can reconsider. We have a way to express it in the test code. If the tests are disabled now, we will enable them in the networking test push which is in progress cc @steveharter @Priya91 @ianhays |
Disabled test, reopen it. |
This test is not tracked in networking push, as it requires special CI infrastructure to run the test, so out of scope of stabilization effort. The test is already there, what's missing is the right version of windows, and setup scripts. One way is to write the powershell script that's required to set the setting, and ensure to execute the script before running the test. cc @davidsh Can you provide more info on which specific Windows version/build number is required for the test, and also the powershell scripts required for configuration. |
This should be Future - it is not blocking 2.0 release |
|
One of the oldest issues #4887 was about the Windows socket option, ReuseUnicastPort. This test was disabled several years ago because it was very difficult to test in CI since it required not only a newer version of Windows but also specific network settings on the machine. At this point, there is not any way to reliably test this. And the end-to-end test isn't really of high value for .NET Core since we would really be mostly testing an OS feature. As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked as Outerloop but didn't need to be. Closes #29929 Closes #21327 Closes #4887
One of the oldest issues #4887 was about the Windows socket option, ReuseUnicastPort. This test was disabled several years ago because it was very difficult to test in CI since it required not only a newer version of Windows but also specific network settings on the machine. At this point, there is not any way to reliably test this. And the end-to-end test isn't really of high value for .NET Core since we would really be mostly testing an OS feature. As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked as Outerloop but didn't need to be. Closes #29929 Closes #21327 Closes #4887
Some Windows CoreFx features like System.Net.Sockets socket option SocketOptionName.ReuseUnicastPort require a specific version of Windows (10) and customized networking configuration using Powershell scripts. And changing these settings requires a machine reboot. This is difficult to test in the current CI environment.
Need to find a way to create 'disposable' test machines/VM's with these customized settings so that these kinds of specific tests can be automated.
The text was updated successfully, but these errors were encountered: