Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][infra] Runtime tests on Android are not getting sent to Helix #107551

Closed
matouskozak opened this issue Sep 9, 2024 · 8 comments · Fixed by #107563
Closed

[android][infra] Runtime tests on Android are not getting sent to Helix #107551

matouskozak opened this issue Sep 9, 2024 · 8 comments · Fixed by #107563
Labels
area-Infrastructure-mono in-pr There is an active PR which will close this issue when it is merged os-android
Milestone

Comments

@matouskozak
Copy link
Member

matouskozak commented Sep 9, 2024

Some recent changes likely from this range 516e81e...57a4b04 caused that Android runtime tests are not properly bundled and sent Helix (SendHelixJob given no WorkItems to send.)

Affected CI:

  • android-x64 Release AllSubsets_Mono_RuntimeTests minijit
  • android-x64 Release AllSubsets_Mono_RuntimeTests_Interp monointerpreter

image

Copy link
Contributor

Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 9, 2024
Copy link
Contributor

Tagging subscribers to this area: @directhex, @matouskozak
See info in area-owners.md if you want to be subscribed.

@matouskozak
Copy link
Member Author

@jkoritzinsky do you think that #107200 could be the cause? I thought that the changes shouldn't affect Mono/Mobile but only this and #107167 from the range looks to be infra related.

@jkoritzinsky
Copy link
Member

Unless Android was only "running" those tests (which are skipped on Android) and not running any other runtime tests, it couldn't be those. Can you check which tests were running beforehand?

@matouskozak
Copy link
Member Author

Unless Android was only "running" those tests (which are skipped on Android) and not running any other runtime tests, it couldn't be those. Can you check which tests were running beforehand?

I think only the profiler tests where running:
image

@jkoritzinsky
Copy link
Member

Well that's really not good....

I'll see if I can get these jobs back to actually doing work. If you want to get these pipelines green in the meantime, you can disable these jobs as you aren't actually losing any test coverage...

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Sep 9, 2024
@matouskozak
Copy link
Member Author

Well that's really not good....

I'll see if I can get these jobs back to actually doing work. If you want to get these pipelines green in the meantime, you can disable these jobs as you aren't actually losing any test coverage...

I agree and I'm unsure why we only used to run profiler tests even though we appear to be building the rest as well. I'll be OOF starting tomorrow but I'll check it out after I come back.

Thank you for looking into it.

@jkoritzinsky
Copy link
Member

I found the issue. There was a change to fix an issue in running the runtime tests on desktop platforms about a year and a half ago which broke all mobile platforms. A later fix re-enabled WASM. I'm using that same fix (as it will work for our use case) for Android.

@vitek-karas vitek-karas added this to the 9.0.0 milestone Sep 10, 2024
@vitek-karas vitek-karas removed the untriaged New issue has not been triaged by the area owner label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-mono in-pr There is an active PR which will close this issue when it is merged os-android
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants