Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS/tvOS] BigInteger tests running out-of-memory #105753

Closed
matouskozak opened this issue Jul 31, 2024 · 8 comments
Closed

[iOS/tvOS] BigInteger tests running out-of-memory #105753

matouskozak opened this issue Jul 31, 2024 · 8 comments
Labels
arch-arm64 area-System.Runtime Known Build Error Use this to report build issues in the .NET Helix tab os-ios Apple iOS os-tvos Apple tvOS
Milestone

Comments

@matouskozak
Copy link
Member

matouskozak commented Jul 31, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=757260&view=ms.vss-test-web.build-test-results-tab&runId=19205408&resultId=107014&paneView=debug
Build error leg or test failing: System.Tests.DecimalTests+BigInteger[Add/Div/Mul].Test
Affected CI: ios_arm64_release_allsubsets_mono, ios_arm64_release_allsubsets_mono
The issues doesn't seem to be 100% reproducible and is failing occasionally on the CI

The first failure on rolling build CI happenned on 24th of July 10:00 (CEST) https://dev.azure.com/dnceng-public/public/_build/results?buildId=753200&view=results corresponding to 703df3b

Stack trace example:

[17:51:30.6376040] 2024-07-26 17:51:30.636 System.Runtime.Tests[40033:121905450] 	[FAIL] System.Tests.DecimalTests+BigIntegerAdd.Test
[17:51:30.6376740] System.OutOfMemoryException : Insufficient memory to continue the execution of the program.
[17:51:30.6377030]    at System.GC.AllocateArray[UInt32](Int32 length, Boolean pinned)
[17:51:30.6378010] 2024-07-26 17:51:30.636 System.Runtime.Tests[40033:121905450]    at System.GC.AllocateUninitializedArray[UInt32](Int32 length, Boolean pinned)
[17:51:30.6378340]    at System.Buffers.SharedArrayPool`1[[System.UInt32, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Rent(Int32 minimumLength)
[17:51:30.6380530] 2024-07-26 17:51:30.636 System.Runtime.Tests[40033:121905450]    at System.Numerics.BigInteger.Multiply(ReadOnlySpan`1 left, Int32 leftSign, ReadOnlySpan`1 right, Int32 rightSign)
[17:51:30.6380990]    at System.Numerics.BigInteger.op_Multiply(BigInteger left, BigInteger right)
[17:51:30.6381220]    at System.Tests.DecimalTests.BigDecimal.Add(BigDecimal value, Boolean& overflow)
[17:51:30.6381330] 2024-07-26 17:51:30.636 System.Runtime.Tests[40033:121905450]    at System.Tests.DecimalTests.BigIntegerAdd.Test()
[17:51:30.6381450]    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[17:51:30.6381530]    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
[16:51:43.0371740] 2024-07-29 13:51:43.082 System.Runtime.Tests[36143:107068255] 	[FAIL] System.Tests.DecimalTests+BigIntegerMul.Test
[16:51:43.0372230] Assert.Equal() Failure: -6773724285713928637.9 * 0.000000000000001533938174
[16:51:43.0372340] Expected: 0.0000000000000000000000000
[16:51:43.0372420] Actual:   -10390.474262007477981186633195
[16:51:43.0372510] 2024-07-29 13:51:43.082 System.Runtime.Tests[36143:107068255]    at System.Tests.DecimalTests.BigIntegerMul.Test()
[16:51:43.0372600]    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[16:51:43.0372690]    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
[16:51:43.0390030] 2024-07-29 13:51:43.084 System.Runtime.Tests[36143:107068255] System.Tests.DecimalTests+BigIntegerMul 0.096197 ms
[16:51:43.0391760] 2024-07-29 13:51:43.085 System.Runtime.Tests[36143:107068255] 

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage":,
  "ErrorPattern": "(System\\.OutOfMemoryException : Insufficient memory to continue the execution of the program\\.)|(Assert\\.Equal\\(\\) Failure: -23057707503038771933 \\* -1)|(Assert\\.Equal\\(\\) Failure: -6773724285713928637\\.9 \\* 0\\.000000000000001533938174)",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Report

Build Definition Test Pull Request
757260 dotnet/runtime System.Tests.DecimalTests+BigIntegerAdd.Test

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 1

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=763399
Error message validated: [(System\.OutOfMemoryException : Insufficient memory to continue the execution of the program\.)|(Assert\.Equal\(\) Failure: -23057707503038771933 \* -1)|(Assert\.Equal\(\) Failure: -6773724285713928637\.9 \* 0\.000000000000001533938174)]
Result validation: ❌ Known issue did not match with the provided build.
Validation performed at: 8/7/2024 5:25:59 PM UTC

@matouskozak matouskozak added arch-arm64 untriaged New issue has not been triaged by the area owner os-ios Apple iOS os-tvos Apple tvOS Known Build Error Use this to report build issues in the .NET Helix tab labels Jul 31, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 31, 2024
Copy link
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Tagging subscribers to 'os-tvos': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@matouskozak matouskozak added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 31, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

@matouskozak
Copy link
Member Author

No longer failing on rolling-builds.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Aug 5, 2024
@matouskozak
Copy link
Member Author

@matouskozak matouskozak reopened this Aug 7, 2024
@matouskozak matouskozak added the untriaged New issue has not been triaged by the area owner label Aug 7, 2024
@matouskozak matouskozak added this to the 9.0.0 milestone Aug 7, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Aug 7, 2024
@jeffhandley jeffhandley modified the milestones: 9.0.0, Future Aug 8, 2024
@matouskozak
Copy link
Member Author

matouskozak commented Aug 12, 2024

There seems to be something off with fullAOT-llvm on Apple mobile. The failures are very occasional and coming from different BigInteger test. Fyi: @steveisok @vitek-karas
image

@vitek-karas
Copy link
Member

@matouskozak Could you please create a separate issue for the functional failures - the title of this one talks just about OOM conditions which are probably much less of a problem. Computing wrong results is more serious problem.

@matouskozak
Copy link
Member Author

Likely fixed by #106313

@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-System.Runtime Known Build Error Use this to report build issues in the .NET Helix tab os-ios Apple iOS os-tvos Apple tvOS
Projects
None yet
Development

No branches or pull requests

3 participants