Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineArrayAttribute should allow for vectorization #103712

Closed
AaronRobinsonMSFT opened this issue Jun 19, 2024 · 3 comments
Closed

InlineArrayAttribute should allow for vectorization #103712

AaronRobinsonMSFT opened this issue Jun 19, 2024 · 3 comments

Comments

@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented Jun 19, 2024

Default implementations of Equals() and GetHashCode() now throw. It is expected for them to be implemented by users. How this was done though, does result in a lost opportunity. See comment below.

This is an unfortunate consequence of throwing.

We'd otherwise be able to treat InlineArray of primitive types as bitwise equatable and allow them to participate in some of the vectorization speedups.

It would be nice if there was a better way to allow users to override the default while still opting their types into bitwise equality support.

Originally posted by @tannergooding in #103612 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 19, 2024
@AaronRobinsonMSFT AaronRobinsonMSFT added area-System.Runtime.CompilerServices and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the Future milestone Jun 19, 2024
@AaronRobinsonMSFT AaronRobinsonMSFT removed the untriaged New issue has not been triaged by the area owner label Jun 19, 2024
@MichalPetryka
Copy link
Contributor

Duplicate of #75642?

@AaronRobinsonMSFT
Copy link
Member Author

Duplicate of #75642?

Agreed.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants