Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BinFmt] Opt-in warn on Custom BuildEventArgs usage #9008

Closed
Tracked by #6215
JanKrivanek opened this issue Jul 11, 2023 · 0 comments
Closed
Tracked by #6215

[BinFmt] Opt-in warn on Custom BuildEventArgs usage #9008

JanKrivanek opened this issue Jul 11, 2023 · 0 comments

Comments

@JanKrivanek
Copy link
Member

Background

#6215
This subitem is focused on FullFw usages of custom BuildEventArgs.
Custom BuildEventArgs currently uses BinaryFormatter for de/serialization: https://github.com/dotnet/msbuild/blob/main/src/Shared/LogMessagePacketBase.cs#L377 This is going to be resolved for Core as in #8823. The fixing PR introduces warning for Core in case the Custome BuildEventArgs are attempted to be serialized (here and here). In order to allow easier depart of Custom BuildEventArgs for FullFw builds - we want to introduce opt-in mechanism issuing same warnings.

Goal

Same warnings as introduced in #8917 (see links above for precise location) can be opted-in for FullFw build

Suggested approach

Define global property that will enable #ifdefed code introduced in the mentioned PR.
Create FullFW unit test verifying the warning is issued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants