Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlazorWebView packaging change proposal #1283

Closed
Eilon opened this issue Jun 11, 2021 · 3 comments
Closed

BlazorWebView packaging change proposal #1283

Eilon opened this issue Jun 11, 2021 · 3 comments
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView t/enhancement ☀️ New feature or request

Comments

@Eilon
Copy link
Member

Eilon commented Jun 11, 2021

There was a recent discussion about ideas on changing how BlazorWebView is packaged. Right now to use BlazorWebView you have to reference a package, set your project to use an SDK, and potentially some other settings. We can hide much of that via targets/props in the package, but we want to consider having something like UseBlazorWebView as an MSBuild property. To solve everything we need to consider changes to the Razor SDK to be always-imported (but perhaps only conditionally enabled).

Ideas:

  • Always import Razor SDK props
  • Only import targets is UseBlazorWebView is set
  • Change to a Framework Pack
@Eilon Eilon added the area-blazor Blazor Hybrid / Desktop, BlazorWebView label Jun 11, 2021
@Daniellled
Copy link

This brings up a good question. I see we still have two project templates

dotnet new maui
and
dotnet new maui-blazor

Are you proposing that only one project template exist
dotnet new maui
And if you need to use BlazorWebview you can include the package?

@Eilon
Copy link
Member Author

Eilon commented Aug 3, 2021

@Daniellled I think there would still be 2 templates because they would have different contents. But we could possibly make it easier to add BlazorWebView to an existing .NET MAUI project with these suggestions.

@jsuarezruiz jsuarezruiz added the t/enhancement ☀️ New feature or request label Nov 12, 2021
@mkArtakMSFT
Copy link
Member

@Eilon closing this as our template story is finalized at this point. Let us know if you want to discuss this.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView t/enhancement ☀️ New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants