Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.3] Fix event counter issues and add test patterns for event source testing #23826

Merged
merged 2 commits into from
Jan 13, 2021

Commits on Jan 6, 2021

  1. [5.0.3] Fix event counter issues and add test patterns for event sour…

    …ce testing
    
    Fixes #23630
    
    **Description**
    
    Three event counters don't get updated when the async API is used (as opposed to the sync one). An additional event counter is incorrectly updated, and so show wrong results.
    
    **Customer Impact**
    
    Our newly-introduced event counters show incorrect data which does not take into account async calls.
    
    **How found**
    
    Customer reported an issue on 5.0.0 with one counter, the rest discovered via due diligence.
    
    **Test coverage**
    
    Test coverage added after investigation and discussion of the best way to do it. We settled on using reflection to access the counters and then configuring the tests to not run in parallel. These tests are both for detecting regressions, and so that going forward we can test new event counters to avoid mistakes like this in the future.
    
    **Regression?**
    
    No, event counters are new in 5.0.0.
    
    **Risk**
    
    Very low, add missing counter updates which are already in place and working for the sync versions, and move the location of another counter update. Only affects the new event counters feature.
    ajcvickers committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    9b1d026 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Review feedback

    ajcvickers committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    9edaf94 View commit details
    Browse the repository at this point in the history