Move Thread_safety_in_relational_command_cache out of QueryBugsTest

[roji]

As part of dotnet/SqlClient#1234, it turns out we have a concurrent test (Thread_safety_in_relational_command_cache) in QueryBugsTest, which reuses the same SqlConnection instance. This isn't an actual problem at the moment since SqlClient's unmanaged Windows networking implementation seems fully thread-safe, but this test would fail badly on Linux/Mac. It also fails/blocks on SqlClient 4.0.0-preview.1.

[smitpatel]

Move where though?

[roji]

I don't know :) We'd have to think of something.

[roji]

BTW maybe it can just be in on of the regular test suites - it doesn't need any specific database schema, so any test suite where DbContext instances don't share DbConnections should be fine...

[smitpatel]

I mean what issue the test particularly have inside query bugs test? As part of deprecating QueryBugsTest, we have non shared model tests which are somewhat provider agnostic.

[roji]

Maybe in SqlServerEndToEnd tests?

[AndriySvyryd]

To make that test use connection string replace the first line with

var contextFactory = await InitializeAsync<MyContext21666>(
    onConfiguring: options =>((IDbContextOptionsBuilderInfrastructure)options).AddOrUpdateExtension(
        options.Options.FindExtension<SqlServerOptionsExtension>()
            .WithConnection(null)
            .WithConnectionString(SqlServerTestStore.CreateConnectionString(StoreName))));