Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: Reduce the number of convention executions #15897

Open
Tracked by #22952
AndriySvyryd opened this issue Jun 1, 2019 · 0 comments
Open
Tracked by #22952

Perf: Reduce the number of convention executions #15897

AndriySvyryd opened this issue Jun 1, 2019 · 0 comments

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jun 1, 2019

  • Validate ConventionSet doesn't have duplicate convention registrations
  • When executing delayed conventions prune redundant ones
    • Latter invocations overriding former ones: PropertyRemoved after PropertyNullabilityChanged
    • Cancelling-out invocations: IndexAdded after IndexRemoved on the same properties
  • Don't call conventions when resetting to default value that is the same as the current one
  • Don't store delayed convention executions if no conventions are registered
  • Store derived types to improve DerivedTypeDiscoveryConvention perf
@ajcvickers ajcvickers added this to the Backlog milestone Jun 3, 2019
@AndriySvyryd AndriySvyryd changed the title Perf: Conventions Perf: Reduce the number of convention executions Aug 22, 2019
@AndriySvyryd AndriySvyryd self-assigned this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants