This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix SNIPacket.ReadFromStreamAsync to not consume same ValueTask twice #42338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via an analyzer I'm working on for ValueTasks. This calls stream.ReadAsync, and in the case where the ValueTask completes successfully by the time the code checks and where the returned Result <= 0, it then awaits the ValueTask again, representing a second consumption when only one is considered legal. Fix it by replacing the original ValueTask with a new one containing the same result.
scalablecory
approved these changes
Nov 3, 2019
davidsh
approved these changes
Nov 4, 2019
|
/cc @cheenamalhotra @David-Engel @Wraith2 This should probably be replicated into https://github.com/dotnet/sqlclient. |
Yup. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via an analyzer I'm working on for ValueTasks.
This calls stream.ReadAsync, and in the case where the ValueTask completes successfully by the time the code checks and where the returned Result <= 0, it then awaits the ValueTask again, representing a second consumption when only one is considered legal.
Fix it by replacing the original ValueTask with a new one containing the same result.