Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign to remove PipelineResult.NotRun #2443

Open
KathleenDollard opened this issue Jun 17, 2024 · 0 comments
Open

Redesign to remove PipelineResult.NotRun #2443

KathleenDollard opened this issue Jun 17, 2024 · 0 comments
Labels
Powderhouse Work to isolate parser and features

Comments

@KathleenDollard
Copy link
Contributor

@Keboo correctly questioned the behavior or the NotRun method of PipelineResult which did nothing.

In the current design, this method could be removed (it is currently called from CliSubstem) or could reset the default values. Doing nothing is wrong.

However, it appears to point to a deeper issue. Multiple subsystems will be called, and we should track these in a thoughtful way.

Initial thoughts:

  • Should we track calling "normal pipeline subsystems" such as validation
  • We currently allow subsystems to run even if the result is already handled (already handled, should be a different terminating subsystem). This design may be important for cleanup, but should we have an absolute restriction to exactly one terminating subsystem. If this is not the decision, the PipelineResult needs to be changed. (Note CheckIfActivated blocks running unneeded subsystems, so it is a niche case if more than one is needed)

If we have exactly one terminating subsystem, we may want the current design plus a list of subsystems that run. If we allow multiple terminating subsystems, then we probably want a list of all subsystems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Powderhouse Work to isolate parser and features
Projects
None yet
Development

No branches or pull requests

1 participant