ApiCompat $(ApiCompatBaseline) variable ignored..

[danwalmsley]

• This issue is blocking
• This issue is causing unreasonable pain

I have an apidiff.props... ApiCompat is setup and working...

however I would like to define where the baseLine textfile lives.

<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup>
    <ApiContractPackageVersion>0.10.0-preview1</ApiContractPackageVersion>
    <NugetPackageName Condition="'$(PackageId)' != ''">$(PackageId)</NugetPackageName>
    <NugetPackageName Condition="'$(PackageId)' == ''">Avalonia</NugetPackageName>    

    <ApiCompatExcludeAttributeList>$(MSBuildThisFileDirectory)..\Tools\apiCompat\ApiCompatExcludeAttributeList.txt</ApiCompatExcludeAttributeList>
    <ApiCompatBaseline>$(MSBuildThisFileDirectory)..\Tools\apiCompat\baseline\ApiCompatBaseline.txt</ApiCompatBaseline>
  </PropertyGroup>
    <ItemGroup>
    <PackageDownload Include="$(NugetPackageName)" Version="[$(ApiContractPackageVersion)]" />
      <PackageReference Include="Microsoft.DotNet.ApiCompat" Version="5.0.0-beta.20364.3" PrivateAssets="All" />
    <ResolvedMatchingContract Include="$(NuGetPackageRoot)\$(NugetPackageName.ToLower())\$(ApiContractPackageVersion)\lib\$(TargetFramework)\$(AssemblyName).dll" />
    </ItemGroup>
</Project>

no matter what $(ApiCompatBaseline) is set to, the file ends up next to the csproj.

ping @jkoritzinsky

[danwalmsley]

Also $ApiCompatExcludeAttributeList seems to be ignored also.

[ViktorHofer]

cc @ericstj

[ericstj]

ApiCompatBaseline property is only redefined if the file doesn't exist.

arcade/src/Microsoft.DotNet.ApiCompat/src/build/Microsoft.DotNet.ApiCompat.targets

Lines 31 to 32 in 39c3b73

	<ApiCompatBaseline Condition="!Exists('$(ApiCompatBaseline)')">$(MSBuildProjectDirectory)\ApiCompatBaseline.$(_apiCompatTargetSuffix).txt</ApiCompatBaseline>
	<ApiCompatBaseline Condition="!Exists('$(ApiCompatBaseline)')">$(MSBuildProjectDirectory)\ApiCompatBaseline.txt</ApiCompatBaseline>

Do you have a suggestion for the behavior you'd like to see? Would you like to submit a PR?