Merge SqlDelegatedTransaction #2861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1261.
This PR merges the SqlDelegatedTransaction class. It's slightly more complex, because it introduces a behaviour change in the .NET Framework class. I think the change is correct though.
Line 262 of the .NET Framework class was formerly:
It's now on line 257:
This changes the .NET Framework class to align with the .NET Core codebase. Historically, both conditions were identical between codebases; PR #1216 changed this to fix a bug in .NET Core, in the process swapping the condition from
!=to==in .NET Framework. I'm pretty sure this was just a typo, and the merge will correct that.