Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code files #2814

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edwardneal
Copy link
Contributor

Related to #1261, but doesn't merge anything.

There are a few code files which were merged in earlier PRs, but one of the copies was left in place. This PR just cleans these up so we have a clearer picture of the remaining merges.

The other file is netfx/SqlGenericUtil. This class is referenced in the project, but not used anywhere.

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.07%. Comparing base (6d33e9d) to head (5986e1a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2814      +/-   ##
==========================================
+ Coverage   72.03%   72.07%   +0.03%     
==========================================
  Files         305      304       -1     
  Lines       61804    61801       -3     
==========================================
+ Hits        44522    44544      +22     
+ Misses      17282    17257      -25     
Flag Coverage Δ
addons 92.90% <ø> (ø)
netcore 75.93% <ø> (+0.02%) ⬆️
netfx 70.26% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JRahnama
Copy link
Member

@edwardneal, these PRs are crucial in achieving our goal of having a single .csproj file for both .NET Core and .NET Framework. We have already converted the .NET Framework project to the SDK-style format, and our next step is to consolidate both projects into a single .csproj file. Your efforts are really appreciated.

@edwardneal
Copy link
Contributor Author

Thanks - it'll be good to see the merge completed, although I'm conscious that I've not touched the core TdsParser/SqlConnection/SqlCommand classes much yet. Hopefully we'll be able to enable some new functionality (such as Always Encrypted for SqlClient on Linux) along the way too.

@DavoudEshtehari DavoudEshtehari added the ➕ Code Health Changes related to source code improvements label Aug 27, 2024
@DavoudEshtehari DavoudEshtehari added this to the 6.0-preview2 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Changes related to source code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants