Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eng | Initial YAML CI pipeline #2575

Merged
merged 18 commits into from
Jul 11, 2024

Conversation

DavoudEshtehari
Copy link
Member

@DavoudEshtehari DavoudEshtehari commented Jun 15, 2024

Some of the features and enhancements along with migration to YAML:

  • Set all multipliers via pipeline parameters to streamline configuration.
  • Initiate the build process for the project and/or package types, depending on the proposed changes.
  • Activate test steps in debug mode using the "Enable debug output" parameter for detailed troubleshooting.
  • Retry functional and manual tests separately.
  • Enhance the multiplier for Managed SNI on Windows and bypass target frameworks that are not relevant.
  • Configure stage extraction based on metadata to ensure consistency:
    • Apply the same settings for both project and package build types.
    • Utilize similar configurations across multiple images from the same pool.
    • Accommodate self-hosted and private agent pools.
    • Filter code coverage results according to the target frameworks.
    • Run x86-specific tests aligned with the target frameworks.
    • Support diverse environments including on-premises, cloud-based, and enclave SQL Servers.
    • Create steps compatible with Windows, Linux, or macOS platforms.
  • Inject additional steps into each test stage using the prebuildSteps parameter within the ci-run-tests-stage template for enhanced customization.

Breaking down the review based on the commits would make it easier to track the changes.

Sample runs:

@DavoudEshtehari DavoudEshtehari added the Infrastructure Use this label for anything within the 'eng' folder that is relevant to the pipelines. label Jun 15, 2024
@DavoudEshtehari DavoudEshtehari added this to the 6.0-preview1 milestone Jun 15, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.58%. Comparing base (55f48c5) to head (4348748).

Current head 4348748 differs from pull request most recent head 397320f

Please upload reports for the commit 397320f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2575      +/-   ##
==========================================
- Coverage   72.58%   72.58%   -0.01%     
==========================================
  Files         310      310              
  Lines       61688    61688              
==========================================
- Hits        44779    44777       -2     
- Misses      16909    16911       +2     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.48% <ø> (+0.04%) ⬆️
netfx 70.44% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions aren't required. But I think consistently adding @self would be cleaner.

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Outdated Show resolved Hide resolved
eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Outdated Show resolved Hide resolved
eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Outdated Show resolved Hide resolved
eng/pipelines/dotnet-sqlclient-ci-core.yml Outdated Show resolved Hide resolved
eng/pipelines/dotnet-sqlclient-ci-core.yml Outdated Show resolved Hide resolved
eng/pipelines/dotnet-sqlclient-ci-core.yml Outdated Show resolved Hide resolved
@David-Engel David-Engel changed the title eng | Initiate YAML CI pipeline eng | Initial YAML CI pipeline Jul 5, 2024
DavoudEshtehari and others added 5 commits July 8, 2024 10:43
Co-authored-by: David Engel <dengel1012@gmail.com>
Co-authored-by: David Engel <dengel1012@gmail.com>
# Conflicts:
#	eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml
@DavoudEshtehari DavoudEshtehari merged commit 784046f into dotnet:main Jul 11, 2024
159 of 173 checks passed
deepaksa1 added a commit to deepaksa1/SqlClient that referenced this pull request Jul 22, 2024
* Updating Azure.Identity version to 1.11.3 (dotnet#2526)

* Fix | Clone of SqlConnection should include AccessTokenCallback (dotnet#2525)

* Enhancement | Add trace logs for packet size (dotnet#2522)

* Merged PR 4583: eng | Fix policheck errors.

Fix policheck errors.

Sample pipeline run which did not have policheck errors:

https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=88114&view=sariftools.scans.build-tab

Related work items: #30279

* Doc | Fix SNI dependencies of 5.1 and 5.2 release notes (dotnet#2537)

* Change | Separate tests for NetFx and NetCore - NetFx-Only Connection String Properties (dotnet#2466)

* Adding TransparentNetworkIpResolution to list of unsupported on platform connection string error messages
Splitting unit test for netfx-only connection string properties such that test does not fail on netcore

* Remove DeprecatedSynonymCount since referencing the unsupported array is not possible

* Fix | Enhance certificate validation (dotnet#2487)

* Hotfix v5.2.1 Release notes (dotnet#2534)

* Improve AccessTokenCallback sample code (dotnet#2543)

* Merged PR 4621: eng | Fix policheck

* Fix | Adjust path for .AssemblyAttributes in obj folder (dotnet#2550)

* Fix | Fixed GenerateSspiClientContext to retry negotiation with default port (dotnet#2559)

* Strong typed diagnostics (dotnet#2226)

* Fix | Replaced System.Runtime.Caching with Microsoft.Extensions.Caching.Memory (dotnet#2493)

* Add | Add SourceLink translation (dotnet#2552)

* Add | Cache TokenCredential objects to take advantage of token caching (dotnet#2380)

* Merged common code base for SqlUtil.cs (dotnet#2533)

* Add scope trace for GenerateSspiClientContext (dotnet#2497)

* Address conflicts (dotnet#2562)

* Addressing conflict (dotnet#2560)

* Merge SqlColumnEncryptionCertificateStoreProvider (dotnet#2521)

* Add | No-op if engineedition is 6 or 11 due to lack of support for ASSEMBLYPROPERTY function (dotnet#2593)

* Change | Remove some unneeded references and update Azure.Identity (dotnet#2577)

* Add test for issue 2456 (dotnet#2457)

* Merged common code base for AlwaysEncryptedKeyConverter (dotnet#2538)

* Merged AlwaysEncryptedKeyConverter.CrossPlatform and AlwaysEncryptedKeyConverter.Cng.

* 3 Small Changes (dotnet#2594)

* * Port sqlclientx datasource changes
* Remove link to missing nuget.config file
* Remove root namespaces from sqlclient csproj files

* Test to see if namespace changes are breaking the pr build

* Reinstate removing the root namespace and fix resource filename generation

* Test fixes to accommodate recent infra changes (dotnet#2646)

* Test fixes to accomodate recent infra changes

* Fix - Don't error when using infinte connect timeout and Entra auth (dotnet#2651)

* eng | Add delay signed to official builds (dotnet#2653)

* eng | Initial YAML CI pipeline (dotnet#2575)

* Fix | Fix decrypt failure to drain data (dotnet#2618)

* [Scheduled Run] Localized resource files from OneLocBuild

* eng | Add Delay sign to ref csprojs (dotnet#2684)

* [Scheduled Run] Localized resource files from OneLocBuild

* [Scheduled Run] Localized resource files from OneLocBuild

---------

Co-authored-by: Javad Rahnama <v-jarahn@microsoft.com>
Co-authored-by: David Engel <v-davidengel@microsoft.com>
Co-authored-by: Aris Rellegue <v-arellegue@microsoft.com>
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Co-authored-by: Benjamin Russell <russellben@microsoft.com>
Co-authored-by: Aris Rellegue <134557572+arellegue@users.noreply.github.com>
Co-authored-by: dauinsight <145612907+dauinsight@users.noreply.github.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: Daniel Au <v-audaniel@microsoft.com>
Co-authored-by: Wraith <wraith2@gmail.com>
Co-authored-by: SqlClient Azure DevOps <sqlclient@microsoft.com>
Co-authored-by: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Co-authored-by: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com>
Co-authored-by: David Engel <davidengel@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Use this label for anything within the 'eng' folder that is relevant to the pipelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants