Merging SqlConnectionStringBuilder code bases #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DavoudEshtehari
commented
Oct 14, 2021
DavoudEshtehari
commented
- related issue: Possible mergeable classes for merging code bases #1261.
- Common Type: SqlConnectionStringBuilder
- I used if-directives for separation.
- I rearranged members and grouped them in Fields, Private Methods, and Public APIs.
- Null reference members have been removed.
- I chose the better implementation from the existing codebases besides applying some code improvements.
…ilder # Conflicts: # src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs
DavoudEshtehari
requested review from
johnnypham,
Kaur-Parminder,
cheenamalhotra and
JRahnama
DavoudEshtehari
added
the
➕ Code Health
Wraith2
reviewed
Oct 14, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
Wraith2
reviewed
Oct 14, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
Wraith2
reviewed
Oct 14, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
Wraith2
reviewed
Oct 14, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
johnnypham
reviewed
Oct 15, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionStringBuilder.cs
Show resolved
Hide resolved
JRahnama
approved these changes
Oct 18, 2021
cheenamalhotra
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.