Move into Shared for SqlError.cs #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
added
the
➕ Code Health
There was a problem hiding this comment.
Changing the behavior of a public API would cause a breaking change. I think it'd better keep it as same as before and using the OptionalField attribute if we didn't want to announce a breaking change here.
I suggest applying the same behavior for netcore too.
…rties back to fields for serializations and included a serialization test for SqlError
… in NET5 to suppress a test compiler error
|
I noticed there's some compiler error in compiling the new SqlErrorTest in NET5 because the binary serialization is obsolete, I have a fix to that in the next commit |
DavoudEshtehari
approved these changes
Dec 20, 2021
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlErrorTest.cs
Outdated
Show resolved
Hide resolved
Kaur-Parminder
approved these changes
Dec 21, 2021
johnnypham
approved these changes
Jan 18, 2022
johnnypham
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1261 . Merged netfx into netcore for SqlError.cs and move it into shared src and updated the references in the csprojs. I did notice the SqlError in netfx uses the [Serializable] attribute for the class, and has 2 fields that are marked as [System.Runtime.Serialization.OptionalField] with a version number, but in netcore, they've all been switched over to auto properties so they don't get serialized anyway. I ran the functional tests and manual tests for netfx and it seems to be pass and didn't notice any issues, so hopefully we don't need to use them.