Move into Shared for SqlInfoMessageEvent.cs #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and update references in the csprojs
…on and cleaned up IDE0044 to conform with coding style
DavoudEshtehari
added
the
➕ Code Health
|
@lcheunglci There are couple of MDAC codes in netfx. Please move those as well to common file. |
Kaur-Parminder
approved these changes
Oct 5, 2021
johnnypham
approved these changes
Oct 5, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlInfoMessageEvent.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlInfoMessageEvent.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlInfoMessageEvent.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlInfoMessageEvent.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlInfoMessageEvent.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Johnny Pham <v-jopha@microsoft.com>
|
Thanks @johnnypham for the expression bodied getters suggestion. |
cheenamalhotra
requested changes
Oct 16, 2021
lcheunglci
force-pushed
the
MergeShared-SqlInfoMessageEvent
branch
2 times, most recently
from
5ee39b2
to
b591960
Compare
lcheunglci
force-pushed
the
MergeShared-SqlInfoMessageEvent
branch
from
22a4fa6
to
b0e3fa9
Compare
|
Apologies for the spam to the reviewers as I thought we needed to rebase from main, which is a mistake. I've backed out the changes from the rebase, and force pushed it and did a merge with the latest main. |
cheenamalhotra
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1261 . Move the netcore version of SqlInfoMessageEvent.cs to shared src and updated the references for the csprojs.