-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing functionality in batch API #2222
Comments
note that adding net8 triggers a few
on
I also get a build error from |
I'll take a look. |
awesome; I'll go ahead and do what I can with my locally hacked version that targets net7 with the first half of the fixes; I can't test the net8 parameter fix (because that single error is blocking the build), but... that's the small end of the wedge for this |
Relates to #1825
Testing local build (
main
) with Dapper shows a few problems, i.e. "it doesn't work"; severity: IMO critical, this should absolutely be fixed before next build; the batch API is not usable by non-provider scenarios without itSqlConnection
fails tooverride
theCanCreateBatch
andCreateDbBatch()
members (net6+)SqlBatchCommand
doesoverride
theCanCreateParameter
andCreateParameter()
members (net8+), but: the library does not currently build for net8, so: this code is never actually compiled as far as I can seeSuggestions:
for
SqlConnection
:(you may have local rules on docs, especially since we're doing type variance here)
in the csproj:
net8.0
to<TargetFrameworks>
tests:
for net6+
for net8+
The text was updated successfully, but these errors were encountered: