Skip to content

Commit

Permalink
Document C++ runtime requirement in nuspec (#296) (#319)
Browse files Browse the repository at this point in the history
Don't throw exception on invalid app.config files (#287)
  • Loading branch information
David-Engel committed Nov 20, 2019
1 parent 1e8e3b8 commit 976cde4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ internal class SqlAuthenticationProviderManager
static SqlAuthenticationProviderManager()
{
var activeDirectoryAuthNativeProvider = new ActiveDirectoryNativeAuthenticationProvider();
SqlAuthenticationProviderConfigurationSection configurationSection;
SqlAuthenticationProviderConfigurationSection configurationSection = null;
try
{
configurationSection = (SqlAuthenticationProviderConfigurationSection)ConfigurationManager.GetSection(SqlAuthenticationProviderConfigurationSection.Name);
}
catch (ConfigurationErrorsException e)
catch (ConfigurationErrorsException)
{
throw SQL.CannotGetAuthProviderConfig(e);
// Don't throw an error for invalid config files
}
Instance = new SqlAuthenticationProviderManager(configurationSection);
Instance.SetProvider(SqlAuthenticationMethod.ActiveDirectoryIntegrated, activeDirectoryAuthNativeProvider);
Expand Down
3 changes: 3 additions & 0 deletions tools/specs/Microsoft.Data.SqlClient.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ Microsoft.Data.SqlClient.SqlTransaction
Microsoft.Data.SqlClient.SqlParameterCollection
Microsoft.Data.SqlClient.SqlClientFactory

When running on Windows, this library has a dependency on Microsoft.Data.SqlClient.SNI, which requires the Microsoft Visual C++ Redistributable for Visual Studio 2017 to be installed:
https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads

When using NuGet 3.x this package requires at least version 3.4.</description>
<releaseNotes>https://go.microsoft.com/fwlink/?linkid=2090501</releaseNotes>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
Expand Down

0 comments on commit 976cde4

Please sign in to comment.